Skip to content
This repository has been archived by the owner on Jul 5, 2020. It is now read-only.

docConfig not initialised before detectReferenceListRange #5

Closed
jevakallio opened this issue Jun 26, 2020 · 1 comment
Closed

docConfig not initialised before detectReferenceListRange #5

jevakallio opened this issue Jun 26, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@jevakallio
Copy link
Contributor

Via @anku255 on Discord

I was trying to get familiar with the source code of foam-vscode and that's when I noticed that when the function detectReferenceListRange for the first time from here - https://github.com/foambubble/foam-vscode/blob/master/src/extension.ts#L203

The header and footer are calculated incorrectly because the loadDocConfig hasn't run yet and this means docConfig.eol is not correct
This was referenced Jun 26, 2020
Closed
Closed
@jevakallio jevakallio added the bug Something isn't working label Jun 29, 2020
jevakallio added a commit that referenced this issue Jun 29, 2020
@jevakallio
Fixes reference list new lines. Closes #3 #5 #10
60d8f50
@jevakallio jevakallio mentioned this issue Jun 29, 2020
Merged
@jevakallio
Copy link
Contributor Author

Fixed in https://github.com/foambubble/foam-vscode/releases/tag/v0.1.5

jevakallio added a commit that referenced this issue Jul 2, 2020
@jevakallio
Fixes reference list new lines. Closes #3 #5 #10
7bb8e4e
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jevakallio