-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add file ignore setting (issue #300) #304
Conversation
thanks @jmg-duarte, this is looking good. The only question I have is why not using globs? |
The glob library goes hand in hand with the file system and is not usable for matching along lists. |
I am missing something, why is that a problem? |
We could use the globs if we put both the list of files found and the ignored ones in sets and intersected them.
Probably, I'll do some research on it |
It seems to me that the |
hi @jmg-duarte, did you get a chance to look into this? No rush, was thinking of shipping it with 0.5.0 (in one week), but wanted to check your status, thanks! |
I got sidetracked due to the lack of big repositories to profile with. |
I tried to use a set but the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still looks good to me :) but let's update the description of the property so that it's clearer for users
packages/foam-vscode/package.json
Outdated
"array" | ||
], | ||
"default": [], | ||
"description": "List of files/folders Foam should ignore. Paths are relative to the workspace root." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this needs to be updated right? Might also be worth adding an example in parenthesis for clarity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of an example we can set a default .vscode/*
and _layouts/*
for example.
Description wise I'll try to make it clearer since the description is out of date
Hi all -- having trouble with this. My |
Can you show your entry? |
Fixed. Didn't realize I had to I did the following:
Now my graph is once again clean and useable. :) |
This PR is related to issue #300, the issue will be closed and discussion moved here.
This serves as a basic implementation for an ignore mechanism for Foam related files, this is useful to avoid files appearing in the graph (see below).
Before:
After:
Standing problems:
Maybe this should be glob based, to be discussed.
Settings do not refresh, this also happens for other Foam things, such as the graph.