Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore folders at the root of workspace not properly ignored #704

Closed
adrien-perello opened this issue Jul 6, 2021 · 4 comments
Closed
Labels
bug Something isn't working foam-vscode Foam for VSCode extension in packages/foam-vscode help wanted Extra attention is needed
Milestone

Comments

@adrien-perello
Copy link

adrien-perello commented Jul 6, 2021

This is linked to #304

Let's assume that the structure of my workspace in vscode is as follow:

workspace
  ├ foam directory
  | ├ _layout/
  | ├ notes/
  | ├ A/
  | └ index.md
  |
  ├ folder1 (with many other files)
  └ folder2 (with many other files)

From #304, we know how to ignore A/. But I don't manage to ignore all the other files (in folders at the root of the workspace: folder1/, folder2/) from showing up in the graph view.

Screenshot from 2021-07-06 13-24-38

I added "foam.files.ignore": [] in 'settings.json' in both the workspace and the user (I also tried adding ../ in front of the paths), but it does not ignore the folders. Only the folders that are inside my 'foam directory' seems to be ignorable.

And I much rather avoid having several vscode windows opened 😅 Any clue how we could go about it? 😃

@riccardoferretti riccardoferretti changed the title ignore folders at the root of workspace in graph view ignore folders at the root of workspace not properly ignored Jul 6, 2021
@riccardoferretti riccardoferretti added bug Something isn't working foam-vscode Foam for VSCode extension in packages/foam-vscode help wanted Extra attention is needed labels Jul 6, 2021
@pderaaij
Copy link
Collaborator

pderaaij commented Jul 10, 2021

Just wondering, given it's a glob I would wonder if /*/folder1 would work or perhaps /**/folder1 could work? Might be interesting to give a try and see if that solves it?

@riccardoferretti
Copy link
Collaborator

My guess (without having looked closely at the implementation) is that the glob use the workspace folder as root (/), so it won't filter by that.
In a way it's as if the workspace folders namespace is unified before the globbing takes place.
This needs to be validated, it's just my hunch atm

@pderaaij
Copy link
Collaborator

I would expect that when #730 is merged, you can ignore the folders successfully by using a glob as /folder1 of /**/folder1

@riccardoferretti riccardoferretti added this to the 1.0.0 milestone Dec 2, 2021
@riccardoferretti
Copy link
Collaborator

Closing as I believe it's been fixed and has been inactive for a long time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working foam-vscode Foam for VSCode extension in packages/foam-vscode help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants