Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External Workspaces #1418

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

guestieng
Copy link

The requested changes make it possible to choose between two basic types of workspaces for the notes and templates:

  1. "internal" VSCode workspace: Watch and access the note and template folders within "internal" workspace (exclusive VSCode workspace)
  2. "external" workspace: Watch and access the note and template folders within 'external' workspace ("external" with respect to VSCode workspace; INFO: this may include folders from the "internal" VSCode workspace)

The switch may be done via the config. property foam.files.workspaceType .

This feature allows to decouple the essential foam workspace from the VSCode workspace and provides better flexibility and less workflow complexity, particularly when working with multiple VSCode workspaces and projects.

The "external" and absolute note folder paths that are to be watched can be defined via the config. property
foam.files.externalWatchPaths .
The external and absolute template root directory path may be defined via the config. property foam.files.externalTemplatesRoot .

NOTE: The "external" path definitions may be defined such that either only a respective root directory or, in addition, a glob pattern is provided.

…on flag is only available when targeting 'es2022' or later."
… part of VSCode workspace

- allow defining templates in external workspace folders
- added config. properties: foam.files.workspaceType, foam.files.externalWatchPaths, foam.files.externalTemplatesRoot
@riccardoferretti
Copy link
Collaborator

Thanks for the contribution @guestieng
Can you help me better understand the problem this PR addresses? Specifically, what user set up and/or use case is this meant to help with? Is there something that wouldn't be "reproducible" using workspaces with multiple folders?
In terms of Foam direction, especially in the context of using it as a web extension, I fear that the idea of "external" workspace would not easily work or require special handling. Do you have an idea of how that would work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants