[#632] Add test for radios in a form #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can't repro the issue, but might as well keep the test since we seem to like fieldsets but not forms for some reason.
|
Codecov Report
@@ Coverage Diff @@
## beta-530 #638 +/- ##
=========================================
Coverage 97.61% 97.61%
=========================================
Files 1 1
Lines 210 210
Branches 101 101
=========================================
Hits 205 205
Misses 5 5 Continue to review full report at Codecov.
|
stefcameron
added a commit
that referenced
this pull request
Apr 20, 2022
stefcameron
added a commit
that referenced
this pull request
Apr 20, 2022
* chore(dev): declarative shadow root test fixtures - new development shadow-root-utils - refactor setupFixture to render using new utils - refactor current shadow dom tests to use declarative root - debug page renders shadow root fixtures correctly * feat: separate radio light/shadow dom groups * feat: detect display across shadow boundaries * feat: scan through shadow boundary - iterate down dom instead of query when getShadowRoot is provided - new candidate list/tree format with scoped lists * chore(types): added getShadowDom to types * fix: type of getShadowRoot option * test: add test to locate tabbable host * feat: slot elements are not focusable/tabbable * chore: added some jsdocs * refactor: modernize syntax - as requested in PR * Prepare for 5.3.0-beta.0 * 5.3.0-beta.0 * Adjusting code after #604 and comments * Disable shadow DOM for isFocusable/isTabbable if getShadowRoot not given This goes along with disabling it for `tabbable()` and `focusable()` when the option isn't given. * Clarify getShadowRoot must be set to enable shadow DOM support * Add support for `getShadowRoot: true` Note this is the equivalent of `getShadowRoot: () => false` which simply enables shadow DOM support for all open shadows. * Prepare for v5.3.0-beta.1 * 5.3.0-beta.1 * Add prepublishOnly script for manual publishing * fix(index.js) The tabIndex of audio, video and details was left to the default if set to some NaN (#610) * fix(index.js) The tabIndex of contentEditable elements was assumed to be zero in any case, not only in the case it was not specifically set. * Simplified and optimized 'getTabIndex'. * Made better use of short-circuit evaluation in 'isNodeMatchingSelectorTabbable', reducing the chances to call the computationally expensive 'isNodeMatchingSelectorFocusable'. * (Re)Added 'isScope' parameter to 'getTabIndex'. This parameter wasn't present in the master branch, so I lost it in the rebase process. * Added tests for a `contenteditable` with negative tab index. * Fixed bug, now the getTabIndex can return 0 not only when the tabindex is not explicitly set, but also when is set to a value that gives NaN when parsed as integer (which would have been resulted in the default browser tabIndex, as if the tabindex wasn't set at all). Also added test for the case an element has a tab index that can't be turned into an integer. * Added changeset, added entry in CHANGELOG.md and wrote more tests. * Be consistent with asterisks * Sync package.json/yarn.lock with beta-530 base branch Co-authored-by: Stefan Cameron <[email protected]> * [#632] Add test for radios in a form (#638) Can't repro the issue, but might as well keep the test since we seem to like fieldsets but not forms for some reason. * Add changeset for shadow root support Co-authored-by: Ido Rosenthal <[email protected]> Co-authored-by: DaviDevMod <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can't repro the issue, but might as well keep the test since we
seem to like fieldsets but not forms for some reason.
PR Checklist
Please leave this checklist in your PR.
typeof document/window !== 'undefined'before using it in code that gets executed on load.yarn changesetlocally to add one, and follow the prompts).