Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model and module request #10

Closed
Vkzem opened this issue Feb 8, 2024 · 7 comments
Closed

Model and module request #10

Vkzem opened this issue Feb 8, 2024 · 7 comments

Comments

@Vkzem
Copy link

Vkzem commented Feb 8, 2024

Hi Fofr big fan of your work :)

Could I kindly request:

  1. GroundingDino/SAM modules+models that underpin this linked repo
  2. ComfyUI_ImageProcessing nodes
  3. WAS node suite

If helpful, for 1. above's models, it looks like model GroundingDINO_SwinB is saved in models/grounding-dino and sam_vit_h is saved in models/sams.

One other question - is there a way we can upload our own custom LORA to this setup at predict-time?

Thank you very much!

@fofr
Copy link
Owner

fofr commented Feb 9, 2024

I'm working on adding WAS node suite now, I'll take a look at the other modules once that one is working. It's big and complex, but has been requested a lot now.

@fofr
Copy link
Owner

fofr commented Feb 9, 2024

No way to upload custom LoRA at the moment

@Vkzem
Copy link
Author

Vkzem commented Feb 9, 2024

Thanks a lot - appreciate your hard work 🙏

@fofr
Copy link
Owner

fofr commented Feb 18, 2024

This PR adds support for the SAM weights:
#22

Still working on WAS nodes.

@fofr
Copy link
Owner

fofr commented Feb 20, 2024

PR to add WAS nodes:
#25

@fofr
Copy link
Owner

fofr commented Feb 20, 2024

PR to add comfyui_segment_anything:
#26

@fofr
Copy link
Owner

fofr commented Feb 20, 2024

Hi @Vkzem – I'm probably not going to add ComfyUI_ImageProcessing as it isn't a super popular custom node.

Otherwise I think everything you requested is now added.

@fofr fofr closed this as completed Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants