Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WAS custom node support #25

Merged
merged 9 commits into from
Feb 20, 2024
Merged

Add WAS custom node support #25

merged 9 commits into from
Feb 20, 2024

Conversation

fofr
Copy link
Owner

@fofr fofr commented Feb 20, 2024

One of the most requested custom nodes:
https://github.com/WASasquatch/was-node-suite-comfyui

Some of the nodes in WAS are not supported. Partly to reduce scope of this PR, but also because often the implementation is better elsewhere (eg SAM).

Node Name Description
BLIP Model Loader BLIP version 1 not supported by Transformers
BLIP Analyze Image BLIP version 1 not supported by Transformers
CLIPTextEncode (NSP) Makes an HTTP request out to a Github file
Diffusers Model Loader Diffusers is not going to be included as a requirement for this custom node
Diffusers Hub Model Down-Loader Diffusers is not going to be included as a requirement for this custom node
SAM Model Loader There are better SAM Loader modules to use. This implementation is not supported
Text Parse Noodle Soup Prompts Makes an HTTP request out to a Github file
Text Random Prompt Makes an HTTP request out to Lexica, which is unsupported
True Random.org Number Generator Needs an API key which cannot be supplied
Image Seamless Texture img2texture dependency has not been added
Image Rembg (Remove Background) rembg dependency has not been added because it causes custom nodes to fail
MiDaS Model Loader WAS MiDaS nodes are not currently supported
MiDaS Mask Image WAS MiDaS nodes are not currently supported
MiDaS Depth Approximation WAS MiDaS nodes are not currently supported
Text File History Loader History is not persisted

@fofr fofr merged commit db61e23 into main Feb 20, 2024
@fofr fofr deleted the add-WAS-nodes branch February 20, 2024 14:12
@fofr fofr mentioned this pull request Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant