Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ComfyUI broken pipe errors seen in v0.9.13 of cog and upwards #172

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

fofr
Copy link
Owner

@fofr fofr commented Sep 23, 2024

When running a ComfyUI workflow on cog v0.9.13 and upwards, the workflow would seem to randomly just stop and there would be no output. On adding error logging a broken pipe error was reported.

The error would always stop at the point where it would attempt to print or log something (like tqdm or otherwise).

ComfyUI is running in a subprocess (and the server it runs has some async methods), and the model gets updates from webhooks, which it prints. But at the same time Comfy is printing it's own outputs (like inference steps) which are also useful.

It seems to be related to this change in cog:
replicate/cog#1802

The fix here is to capture all stdout/stderr from the subprocess and log it separately.

@fofr fofr merged commit 6174e6c into main Sep 23, 2024
@fofr fofr deleted the fix-broken-pipe branch September 23, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant