Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverage integration into PR workflow #371

Closed
3 tasks done
Temikus opened this issue Jun 25, 2018 · 6 comments
Closed
3 tasks done

Coverage integration into PR workflow #371

Temikus opened this issue Jun 25, 2018 · 6 comments

Comments

@Temikus
Copy link
Member

Temikus commented Jun 25, 2018

Bringing out an item from #370 here, since this is pending Fog org action.

  • Add codecov bot or give fog-google-bot permissions to display coverage
  • Figure out automatic comments on PR's with coverage up/down
  • Make sure master branch has coverage
@Temikus
Copy link
Member Author

Temikus commented Jun 25, 2018

@geemus @plribeiro3000 I’ve requested codecov.io integration for fog-google repo. Requires org approval apparently to add their bot account.

If you think that’s too much - no worries, let me know and I'll figure something out.

We cannot use coveralls since they don’t support merged reports well and we need to do parallel testing (whole test suite takes almost 3 hours if we run sequentially).

Apologies for bothering you folks m(_ _)m

EDIT: removed the YAML instructions since we don't want the whole org to use our bot (d'oh).

@geemus
Copy link
Member

geemus commented Jun 25, 2018

@Temikus I believe it should be approved now, just let me know if you need anything else. Thanks!

@plribeiro3000
Copy link
Member

👍

@Temikus
Copy link
Member Author

Temikus commented Jun 26, 2018

@geemus Thank you, Sir!

@Temikus
Copy link
Member Author

Temikus commented Jun 26, 2018

Looks like the bot is starting to do its' magic: #373

I'll close this out once I'm sure everything's working (this particular PR doesn't have a base due to being submitted before the bot was approved)

@icco
Copy link
Member

icco commented Jul 22, 2018

This seems to be working, closing!

@icco icco closed this as completed Jul 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants