Restore coverage checks #370

Temikus · 2018-06-24T08:19:32Z

Alright, let's get this ball rolling.

Plan:

Fix Simplecov
Remove Coveralls
Integrate Codecov.io
Update CI to send coverage reports
Figure out automatic comments on PR's with coverage up/down
Figure out a repo coverage badge

Fixes #88

Cannot run those in parallel anyway yet and this is not a huge problem at the moment

This is now working and properly combining reports from parallel runners

Temikus · 2018-06-24T08:57:45Z

@icco FYI - we're going to have coverage again soon'ish. Bot integration is pending Fog-org owners approval.

Temikus · 2018-06-24T10:23:58Z

Here's the report: https://codecov.io/gh/fog/fog-google/commit/d137e9cd7637ad22dd0dd0cb9acda92927eedf96

Looks like the basics are working 👍

Temikus · 2018-06-25T02:02:20Z

Acceptance tests are failing:

$ bundle exec rake acceptance:smoke
 1) provider/google/provisioner/shell it should behave like provider/provisioner/shell provisions with the shell script
     Failure/Error: assert_execute("vagrant", "up", "--provider=#{provider}")
       expected command to exit with 0 but got exit code: 1

       stdout: You appear to be running Vagrant outside of the official installers.
       Note that the installers are what ensure that Vagrant has all required
       dependencies, and Vagrant assumes that these dependencies exist. By
       running outside of the installer environment, Vagrant may not function
       properly. To remove this warning, install Vagrant using one of the
       official packages from vagrantup.com.
       Bringing machine 'default' up with 'google' provider...
       ==> default: Launching an instance with the following settings...
       ==> default:  -- Name:            i-2018062511-cab04630
       ==> default:  -- Project:         graphite-sandbox
       ==> default:  -- Type:            n1-standard-1
       ==> default:  -- Disk type:       pd-standard
       ==> default:  -- Disk size:       10 GB
       ==> default:  -- Disk name:
       ==> default:  -- Image:
       ==> default:  -- Image family:    debian-9
       ==> default:  -- Instance Group:
       ==> default:  -- Zone:            us-central1-f
       ==> default:  -- Network:         default
       ==> default:  -- Network Project: graphite-sandbox
       ==> default:  -- Metadata:        '{}'
       ==> default:  -- Labels:          '{}'
       ==> default:  -- Network tags:    '[]'
       ==> default:  -- IP Forward:
       ==> default:  -- Use private IP:  false
       ==> default:  -- External IP:
       ==> default:  -- Internal IP:     #<Object:0x00007fcd4d480720>
       ==> default:  -- Preemptible:     false
       ==> default:  -- Auto Restart:    true
       ==> default:  -- On Maintenance:  MIGRATE
       ==> default:  -- Autodelete Disk: true


       stderr: /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/gems/google-api-client-0.23.0/lib/google/apis/core/http_command.rb:218:in `check_status': invalid: Invalid value for field 'resource.networkInterfaces[0].networkIP': '#<Object:0x00007fcd4d480720>'. Requested internal IP is not a single IP. (Google::Apis::ClientError)
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/gems/google-api-client-0.23.0/lib/google/apis/core/api_command.rb:116:in `check_status'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/gems/google-api-client-0.23.0/lib/google/apis/core/http_command.rb:183:in `process_response'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/gems/google-api-client-0.23.0/lib/google/apis/core/http_command.rb:299:in `execute_once'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/gems/google-api-client-0.23.0/lib/google/apis/core/http_command.rb:104:in `block (2 levels) in execute'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/gems/retriable-3.1.2/lib/retriable.rb:61:in `block in retriable'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/gems/retriable-3.1.2/lib/retriable.rb:56:in `times'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/gems/retriable-3.1.2/lib/retriable.rb:56:in `retriable'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/gems/google-api-client-0.23.0/lib/google/apis/core/http_command.rb:101:in `block in execute'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/gems/retriable-3.1.2/lib/retriable.rb:61:in `block in retriable'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/gems/retriable-3.1.2/lib/retriable.rb:56:in `times'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/gems/retriable-3.1.2/lib/retriable.rb:56:in `retriable'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/gems/google-api-client-0.23.0/lib/google/apis/core/http_command.rb:93:in `execute'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/gems/google-api-client-0.23.0/lib/google/apis/core/base_service.rb:360:in `execute_or_queue_command'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/gems/google-api-client-0.23.0/generated/google/apis/compute_v1/service.rb:6877:in `insert_instance'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/gems/fog-google-1.6.0/lib/fog/compute/google/requests/insert_server.rb:111:in `insert_server'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/gems/fog-google-1.6.0/lib/fog/compute/google/models/server.rb:485:in `save'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/gems/fog-core-2.1.0/lib/fog/core/collection.rb:50:in `create'
       	from /Users/temikus/Dropbox/Code/vagrant-google/lib/vagrant-google/action/run_instance.rb:196:in `call'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/bundler/gems/vagrant-dbba41a7ec3d/lib/vagrant/action/warden.rb:34:in `call'
       	from /Users/temikus/Dropbox/Code/vagrant-google/lib/vagrant-google/action/warn_ssh_keys.rb:28:in `call'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/bundler/gems/vagrant-dbba41a7ec3d/lib/vagrant/action/warden.rb:34:in `call'
       	from /Users/temikus/Dropbox/Code/vagrant-google/lib/vagrant-google/action/warn_networks.rb:28:in `call'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/bundler/gems/vagrant-dbba41a7ec3d/lib/vagrant/action/warden.rb:34:in `call'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/bundler/gems/vagrant-dbba41a7ec3d/lib/vagrant/action/builtin/synced_folders.rb:87:in `call'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/bundler/gems/vagrant-dbba41a7ec3d/lib/vagrant/action/warden.rb:34:in `call'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/bundler/gems/vagrant-dbba41a7ec3d/lib/vagrant/action/builtin/provision.rb:80:in `call'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/bundler/gems/vagrant-dbba41a7ec3d/lib/vagrant/action/warden.rb:34:in `call'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/bundler/gems/vagrant-dbba41a7ec3d/lib/vagrant/action/warden.rb:95:in `block in finalize_action'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/bundler/gems/vagrant-dbba41a7ec3d/lib/vagrant/action/warden.rb:34:in `call'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/bundler/gems/vagrant-dbba41a7ec3d/lib/vagrant/action/builder.rb:116:in `call'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/bundler/gems/vagrant-dbba41a7ec3d/lib/vagrant/action/runner.rb:66:in `block in run'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/bundler/gems/vagrant-dbba41a7ec3d/lib/vagrant/util/busy.rb:19:in `busy'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/bundler/gems/vagrant-dbba41a7ec3d/lib/vagrant/action/runner.rb:66:in `run'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/bundler/gems/vagrant-dbba41a7ec3d/lib/vagrant/action/builtin/call.rb:53:in `call'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/bundler/gems/vagrant-dbba41a7ec3d/lib/vagrant/action/warden.rb:34:in `call'
       	from /Users/temikus/Dropbox/Code/vagrant-google/lib/vagrant-google/action/connect_google.rb:44:in `call'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/bundler/gems/vagrant-dbba41a7ec3d/lib/vagrant/action/warden.rb:34:in `call'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/bundler/gems/vagrant-dbba41a7ec3d/lib/vagrant/action/builtin/box_check_outdated.rb:36:in `call'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/bundler/gems/vagrant-dbba41a7ec3d/lib/vagrant/action/warden.rb:34:in `call'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/bundler/gems/vagrant-dbba41a7ec3d/lib/vagrant/action/builtin/config_validate.rb:25:in `call'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/bundler/gems/vagrant-dbba41a7ec3d/lib/vagrant/action/warden.rb:34:in `call'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/bundler/gems/vagrant-dbba41a7ec3d/lib/vagrant/action/builtin/handle_box.rb:56:in `call'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/bundler/gems/vagrant-dbba41a7ec3d/lib/vagrant/action/warden.rb:34:in `call'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/bundler/gems/vagrant-dbba41a7ec3d/lib/vagrant/action/builder.rb:116:in `call'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/bundler/gems/vagrant-dbba41a7ec3d/lib/vagrant/action/runner.rb:66:in `block in run'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/bundler/gems/vagrant-dbba41a7ec3d/lib/vagrant/util/busy.rb:19:in `busy'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/bundler/gems/vagrant-dbba41a7ec3d/lib/vagrant/action/runner.rb:66:in `run'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/bundler/gems/vagrant-dbba41a7ec3d/lib/vagrant/machine.rb:239:in `action_raw'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/bundler/gems/vagrant-dbba41a7ec3d/lib/vagrant/machine.rb:208:in `block in action'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/bundler/gems/vagrant-dbba41a7ec3d/lib/vagrant/environment.rb:598:in `lock'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/bundler/gems/vagrant-dbba41a7ec3d/lib/vagrant/machine.rb:194:in `call'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/bundler/gems/vagrant-dbba41a7ec3d/lib/vagrant/machine.rb:194:in `action'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/bundler/gems/vagrant-dbba41a7ec3d/lib/vagrant/batch_action.rb:82:in `block (2 levels) in run'

Pay attention to:

==> z1c:  -- Internal IP:     #<Object:0x00007fb273a0e880>

I'll dig around and see where this got misconfigured.

Temikus · 2018-06-25T04:12:21Z

Alright, I'll merge this in to check master coverage logic. Seems not to affect the rest of the lib.
Just update the changelog.

Temikus added 4 commits June 24, 2018 16:17

Remove Coveralls

37b7c66

Combine sql tests back into one

c8ab57f

Cannot run those in parallel anyway yet and this is not a huge problem at the moment

Fix SimpleCov

0432387

This is now working and properly combining reports from parallel runners

Integrate Codecov.io

1009169

Temikus added the integrate label Jun 24, 2018

Attempt codecov.io integration into CI

d137e9c

Temikus added 2 commits June 24, 2018 20:33

Do not require gems not needed at runtime

894ac70

Add codecov.io badge

da38ae9

Temikus mentioned this pull request Jun 25, 2018

Coverage integration into PR workflow #371

Closed

3 tasks

Temikus and others added 2 commits June 25, 2018 14:17

Modify CHANGELOG

f99f731

Merge branch 'master' into restore_coverage

061d961

Temikus merged commit 23f3cf5 into fog:master Jun 25, 2018

Temikus deleted the restore_coverage branch June 25, 2018 04:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Restore coverage checks #370

Restore coverage checks #370

Temikus commented Jun 24, 2018 •

edited

Loading

Temikus commented Jun 24, 2018

Temikus commented Jun 24, 2018

Temikus commented Jun 25, 2018 •

edited

Loading

Temikus commented Jun 25, 2018

Restore coverage checks #370

Restore coverage checks #370

Conversation

Temikus commented Jun 24, 2018 • edited Loading

Temikus commented Jun 24, 2018

Temikus commented Jun 24, 2018

Temikus commented Jun 25, 2018 • edited Loading

Temikus commented Jun 25, 2018

Temikus commented Jun 24, 2018 •

edited

Loading

Temikus commented Jun 25, 2018 •

edited

Loading