Add support for using predefined ACLs, fixes #324

[easkay]

As per issue #324, I decided to make a start on this functionality and would like to know what folks think. I'm not sure which tests need writing and where, especially since things are migrating to minitest. Some guidance would be appreciated.

Also, the changes introduced here are pretty much entirely copied from https://github.com/fog/fog-aws/blob/master/lib/fog/aws/requests/storage/put_object_acl.rb#L39.

[houndci-bot]

Some files could not be reviewed due to errors:

Error: obsolete parameter MaxLineLength (for Style/IfUnlessModifier) found in...

Error: obsolete parameter MaxLineLength (for Style/IfUnlessModifier) found in .rubocop.yml
`Style/IfUnlessModifier: MaxLineLength` has been removed. Use `Metrics/LineLength: Max` instead

[houndci-bot]

Some files could not be reviewed due to errors:

Error: obsolete parameter MaxLineLength (for Style/IfUnlessModifier) found in...

Error: obsolete parameter MaxLineLength (for Style/IfUnlessModifier) found in .rubocop.yml
`Style/IfUnlessModifier: MaxLineLength` has been removed. Use `Metrics/LineLength: Max` instead

[icco]

could you instead change this to an else if where you check if it's a string, and check if it's a valid ACL?

We're also already storing ACLs in a few places. Could you move this list to consistent place as a constant and have all uses of ACL names reference it?

• fog-google/lib/fog/storage/google_xml/models/file.rb

  Lines 20 to 36 in 1b01326

  	# https://cloud.google.com/storage/docs/access-control#predefined-acl
  	VALID_ACLS = [
  	"authenticated-read",
  	"bucket-owner-full-control",
  	"bucket-owner-read",
  	"private",
  	"project-private",
  	"public-read",
  	"public-read-write"
  	].freeze
  	def acl=(new_acl)
  	unless VALID_ACLS.include?(new_acl)
  	raise ArgumentError.new("acl must be one of [#{VALID_ACLS.join(', ')}]")
  	end
  	@acl = new_acl
  	end

• fog-google/lib/fog/storage/google_xml/models/directory.rb

  Line 10 in 07272fa

  valid_acls = ["private", "public-read", "public-read-write", "authenticated-read"]

Thanks!

[icco]

Sorry this review has taken so long @easkay, been running around a lot lately. This overall looks good, but I'd like us to refactor a little to be consistent with how we use shared ACLs.

[easkay]

@icco No worries, thanks for taking a look. I'll work on your feedback later this evening and update the PR. I notice there's no mock for this request either, do you have any suggestions on making one? Not a problem if you don't :)

[houndci-bot]

Some files could not be reviewed due to errors:

Error: obsolete parameter MaxLineLength (for Style/IfUnlessModifier) found in...

Error: obsolete parameter MaxLineLength (for Style/IfUnlessModifier) found in .rubocop.yml
`Style/IfUnlessModifier: MaxLineLength` has been removed. Use `Metrics/LineLength: Max` instead

[icco]

@easkay I was hoping you could update the File and Directory models as well that are using public acls. As for mocks, usually copying the response from google by making the request with curl and then scrubbing data is how it's been done in the past.

[easkay]

@icco Ah, sorry I misunderstood and/or misread. I'll get on that in a few minutes :) Apologies for the misunderstanding.

[houndci-bot]

Some files could not be reviewed due to errors:

Error: obsolete parameter MaxLineLength (for Style/IfUnlessModifier) found in...

Error: obsolete parameter MaxLineLength (for Style/IfUnlessModifier) found in .rubocop.yml
`Style/IfUnlessModifier: MaxLineLength` has been removed. Use `Metrics/LineLength: Max` instead

[easkay]

@icco I wasn't entirely sure where these should live. Utils seems like a good place on the surface of it, what do you think?

[icco]

Looks great!

[icco]

Thanks so much!

[easkay]

@icco You're very welcome, glad I could help :)