Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping Google API client to 0.23 #354

Merged
merged 3 commits into from
Jun 7, 2018
Merged

Conversation

Temikus
Copy link
Member

@Temikus Temikus commented Jun 7, 2018

Fixes #325

@Temikus
Copy link
Member Author

Temikus commented Jun 7, 2018

Welp, something broke in client initialization across minor versions. Sigh.

@Temikus
Copy link
Member Author

Temikus commented Jun 7, 2018

google/apis/resourceviews_v1beta2 has disappeared

@Temikus
Copy link
Member Author

Temikus commented Jun 7, 2018

Yep, that's the API that was decomissioned a while ago and we don't actually have any models/requests of it left. I'll quickly fix this.

Temikus added 2 commits June 7, 2018 21:52
Logger class no longer has (or ever had?) that method
@Temikus
Copy link
Member Author

Temikus commented Jun 7, 2018

All tests pass, merging.

@Temikus Temikus merged commit c064f4d into fog:master Jun 7, 2018
@Temikus Temikus deleted the bump_google_client branch June 7, 2018 23:20
@Temikus Temikus mentioned this pull request Jun 8, 2018
@icco
Copy link
Member

icco commented Jun 8, 2018

Thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants