Fix broken calls to get_object_http_url #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Aug 20, 2018
| @@ -6,12 +6,11 @@ def get_object_http_url(bucket_name, object_name, expires, options = {}) | |||
| raise ArgumentError.new("bucket_name is required") unless bucket_name | |||
| raise ArgumentError.new("object_name is required") unless object_name | |||
|
|
|||
| https_url(options.merge(:headers => {}, | |||
| http_url(options.merge(:headers => {}, | |||
There was a problem hiding this comment.
Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
Also makes the option parameter in get_object_https_url optional.
stanhu
force-pushed
the
sh-fix-broken-get-http-url
branch
from
f0975ed to
154bf89
Compare
|
Relates to carrierwaveuploader/carrierwave#2332 |
|
That is my mistake, should've noticed it during #409 - I'll pull this in when tests pass and roll a new release out. |
This was referenced Aug 21, 2018
Codecov Report
@@ Coverage Diff @@
## master #412 +/- ##
=======================================
Coverage 84.11% 84.11%
=======================================
Files 339 339
Lines 5771 5771
=======================================
Hits 4854 4854
Misses 917 917Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also makes the option parameter in get_object_https_url optional.