WIP Minor test fixes and additions #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addressing fog#451
Would otherwise error out on `unless async` Made the method synchronous by default as well
houndci-bot
reviewed
Mar 28, 2019
Temikus
force-pushed
the
monitoring_test_issue
branch
from
33f3e00 to
d08be6b
Compare
houndci-bot
reviewed
Mar 28, 2019
Temikus
changed the title
This appears to have not worked before at all due to mismatched parameters. Added a test to check the behaviour going forward.
Temikus
force-pushed
the
monitoring_test_issue
branch
from
d08be6b to
67d3d06
Compare
Codecov Report
@@ Coverage Diff @@
## master #452 +/- ##
==========================================
+ Coverage 85.27% 85.65% +0.37%
==========================================
Files 339 339
Lines 5840 5840
==========================================
+ Hits 4980 5002 +22
+ Misses 860 838 -22
Continue to review full report at Codecov.
|
houndci-bot
reviewed
Mar 28, 2019
| address.server = server | ||
| address.reload | ||
| assert_equal( | ||
| server, |
There was a problem hiding this comment.
Layout/FirstParameterIndentation: Indent the first parameter one step more than the start of the previous line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AddressestestsAddresses.server =method will now execute a synchronous operation