Created set machine type request

[gscho]

Adds a set_server_machine_type request. This is useful for changing a server's machine type although the instance must be stopped to do so.

Signed-off-by: gscho [email protected]

[kgaikwad]

In addition to this, would it be possible to add method on server model to change machine_type? This method will be responsible to check status of that server. If stopped then allowed user to do so.

[gscho]

@kgaikwad I could do that, sure. If I understand correctly, the method should raise an error if the server is not stopped:

set_machine_type
   raise unless status is stopped
end

That way we're not implicitly stopping the server.

[Temikus]

Please add a Server model method as mentioned in #485 (comment)
Asking since we're trying to discourage using raw requests.

Otherwise LGTM, thanks for this!

[codecov]

Codecov Report

Merging #485 into master will increase coverage by 2.49%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #485      +/-   ##
==========================================
+ Coverage   86.37%   88.86%   +2.49%     
==========================================
  Files         339      340       +1     
  Lines        6819     5659    -1160     
==========================================
- Hits         5890     5029     -861     
+ Misses        929      630     -299

Impacted Files	Coverage Δ
...compute/google/requests/set_server_machine_type.rb	100% <100%> (ø)
lib/fog/compute/google.rb	100% <100%> (ø)	⬆️
lib/fog/compute/google/models/server.rb	78.36% <100%> (+2.24%)	⬆️
lib/fog/google/sql/mock.rb	61.11% <0%> (-25.99%)	⬇️
lib/fog/google/pubsub/mock.rb	62.5% <0%> (-24.46%)	⬇️
lib/fog/google/requests/sql/import_instance.rb	50% <0%> (-23.92%)	⬇️
lib/fog/google/requests/sql/export_instance.rb	43.75% <0%> (-21.93%)	⬇️
lib/fog/google/models/sql/operations.rb	57.89% <0%> (-14.11%)	⬇️
lib/fog/google/requests/pubsub/list_topics.rb	83.33% <0%> (-4.17%)	⬇️
lib/fog/compute/google/mock.rb	50% <0%> (-11.54%)	⬇️
... and 77 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abb11e9...0e85063. Read the comment docs.

[Temikus]

@gscho Thank you for the tests \o/

Looks there's only one caveat here, the returned resource will give you the full identity (resource link), instead of name (which looks to be correct since different zones have different machine types available):

λ bundle exec rake test TESTOPTS="--name=TestServers#test_set_machine_type"
Started with run options --name=TestServers#test_set_machine_type --seed 16020

TestServers
  test_set_machine_type                                           FAIL (114.00s)
        --- expected
        +++ actual
        @@ -1 +1 @@
        -"n1-standard-2"
        +"https://www.googleapis.com/compute/v1/projects/my-project/zones/us-central1-f/machineTypes/n1-standard-2"
        /Users/temikus/fog-dev/fog-google/test/integration/compute/core_compute/test_servers.rb:28:in `test_set_machine_type'

[gscho]

Thank you @Temikus. I was unable to log into concourse with Chrome, Firefox or Safari (via Github SSO) 😞

[Temikus]

@gscho
Re: PR - looks great, I'll merge this in! :)

Re: Concourse - I'm afraid this is currently by design. Since fog is an infra library it is theoretically possible to expose secrets and concourse doesn't allow for easy arbitrary secret redaction.

It is possible to use mocks and we did so in the past but experience has shown us that the GCP API changes too quickly to have reliable VCR cassettes.

It is on my (mile-long, I admit) todo list, with the following:

• Planning to migrate to drone.io soon'ish which should make publishing the pipeline easier
• Adding more mocks which should allow us to run more of those tests in Travis