Fix Monitoring#create_time_series #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
It seems that the GoogleAPI client has made a breaking change again. The method `create_time_series` no longer exists in the library and looks to have been replaced with `create_project_timeseries` We also need to bump the minimum gem version as this was introduced somewhere around 0.31
|
Alright - this builds ok, but CodeCov seems to give us 500's at the moment so I think we can ignore coverage check for this particular build. |
|
I'll merge this now since it's blocking some other work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that the GoogleAPI client has made a breaking change again.
The method
create_time_seriesno longer exists in the library and looks to have been replaced withcreate_project_timeseries.We also need to bump the minimum gem version as this was introduced somewhere around
0.31