Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update fog-core requirement from <= 2.1.0 to <= 2.3.0" #487

Merged
merged 1 commit into from
Feb 24, 2020

Conversation

Temikus
Copy link
Member

@Temikus Temikus commented Feb 20, 2020

Reverts #481 due to causing a regression around #422

We need to push out a minor release before we can update that.

@codecov
Copy link

codecov bot commented Feb 24, 2020

Codecov Report

Merging #487 into master will increase coverage by 7.55%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #487      +/-   ##
==========================================
+ Coverage   81.41%   88.96%   +7.55%     
==========================================
  Files         339      339              
  Lines        5639     5639              
==========================================
+ Hits         4591     5017     +426     
+ Misses       1048      622     -426     
Impacted Files Coverage Δ
lib/fog/storage/google.rb 80.00% <0.00%> (ø) ⬆️
lib/fog/google/sql/mock.rb 61.11% <0.00%> (ø) ⬆️
lib/fog/google/sql/real.rb 100.00% <0.00%> (ø) ⬆️
lib/fog/google/pubsub/mock.rb 62.50% <0.00%> (ø) ⬆️
lib/fog/google/pubsub/real.rb 100.00% <0.00%> (ø) ⬆️
lib/fog/google/models/sql/flag.rb 100.00% <0.00%> (ø) ⬆️
lib/fog/google/models/sql/tier.rb 100.00% <0.00%> (ø) ⬆️
lib/fog/google/models/sql/user.rb 96.42% <0.00%> (ø) ⬆️
lib/fog/google/models/sql/flags.rb 100.00% <0.00%> (ø) ⬆️
lib/fog/google/models/sql/tiers.rb 100.00% <0.00%> (ø) ⬆️
... and 162 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e0e5fb...56d95c2. Read the comment docs.

@Temikus Temikus merged commit 0cdfd9d into master Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant