Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the ssh key operation synchronous in tests #488

Merged
merged 1 commit into from
Feb 21, 2020

Conversation

Temikus
Copy link
Member

@Temikus Temikus commented Feb 21, 2020

Fixing test flakiness.

It looks like adding ssh keys has become slower since we didn't notice this before.

Fixing test flakiness.

It looks like adding ssh keys has become slower since we didn't notice this before.
@codecov
Copy link

codecov bot commented Feb 21, 2020

Codecov Report

Merging #488 into master will increase coverage by 6.51%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #488      +/-   ##
==========================================
+ Coverage   81.41%   87.92%   +6.51%     
==========================================
  Files         339      339              
  Lines        5639     6809    +1170     
==========================================
+ Hits         4591     5987    +1396     
+ Misses       1048      822     -226
Impacted Files Coverage Δ
lib/fog/compute/google/models/disk_types.rb 90.9% <0%> (ø) ⬆️
lib/fog/compute/google/models/machine_types.rb 86.95% <0%> (ø) ⬆️
lib/fog/compute/google/models/servers.rb 96.22% <0%> (ø) ⬆️
lib/fog/google/requests/sql/insert_user.rb 85.18% <0%> (-14.82%) ⬇️
lib/fog/compute/google/models/zones.rb 100% <0%> (ø) ⬆️
lib/fog/compute/google/models/regions.rb 100% <0%> (ø) ⬆️
...ib/fog/storage/google_json/requests/copy_object.rb 100% <0%> (ø) ⬆️
...fog/storage/google_json/requests/get_bucket_acl.rb 100% <0%> (ø) ⬆️
...b/fog/storage/google_json/requests/list_buckets.rb 100% <0%> (ø) ⬆️
lib/fog/google/requests/sql/delete_ssl_cert.rb 81.13% <0%> (-18.87%) ⬇️
... and 123 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e0e5fb...2d43c88. Read the comment docs.

@Temikus Temikus merged commit 91d9046 into fog:master Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant