Add support to reset Windows passwords

[dvanbrug]

These are a few small changes to add the ability to reset windows passwords as described in #494.

The majority of the code was modified from the Python-based Google provided example: https://github.com/GoogleCloudPlatform/compute-image-windows/blob/master/examples/windows_auth_python_sample.py

I have implemented everything as a Request, though I am not sure if this would be better added to the Server model. My thoughts in favor of the Server model are that the request does not match extremely closely to an API, rather is uses the API to set the Metadata values on an instance. However, the downside to adding it to the Server model is that not all Windows images would have this functionality so it might be more complicated to adjust the Server model.

Resolves #494

[Temikus]

Ok, done with first review pass, please address the linter and comments below.

Again, thank you so much for this! \o/

[Temikus]

@dvanbrug PTAL. If anything is not clear - just let me know! :)

[dvanbrug]

@Temikus, thanks, I'll work through these and post another commit.

[dvanbrug]

@Temikus, as I was moving over to use the Sever model, I ran into a question about the following method.

fog-google/lib/fog/compute/google/models/server.rb

Line 346 in e2ca89b

def serial_port_output

Am I correct in understanding that it is only possible to get output from serial port 1 as that is the default for the request? The request method below allows for the ability to take a port.

fog-google/lib/fog/compute/google/requests/get_server_serial_port_output.rb

Line 26 in e2ca89b

def get_server_serial_port_output(identity, zone, port: nil, start: nil)

As Linux instances also have up to 4 serial ports, should I file a separate issue and pull request for this? It would appear based on this documentation that there are definetly use cases where someone would want to be able to interact with ports 2-4.

https://cloud.google.com/compute/docs/instances/interacting-with-serial-console

Thanks!

[dvanbrug]

@Temikus I think I've addressed all of the comments and linter issues. Thank you for your patience as this has been my first in depth pass at building something in Ruby. Looking forward to your thoughts.

[Temikus]

@dvanbrug Acknowledged, thanks for making the changes! I should have a solid chunk of time in the next 2 days to properly review.

Re: 3 - yes, this allowed to only read serial port 1 - you did the right thing by modifying it, thanks! :)

[Temikus]

@dvanbrug This is really good, thank you so much \o/

Just a couple of minor things, PTAL. We should be good to merge after addressing those.

[dvanbrug]

@Temikus I've addressed all you comments. Thank you again for all the help with this!

[Temikus]

@dvanbrug I think I missed 2 of the earlier comments, so sorry about it. I've resolved all solved threads - can you take a look at the 3 open comments above^

Again, thank you so much for this! :)

[dvanbrug]

@Temikus Ok, I've addressed the three comments. One question, as I've had a lot of changes since the start of the PR, should I squash them all into a single commit?

[Temikus]

@dvanbrug Alright, this looks awesome, thank you so-so much for your contributions and patience :)
Yeah, please squash if you can.

I'll merge this after CI passes.

[codecov]

Codecov Report

Merging #495 into master will increase coverage by 0.37%.
The diff coverage is 87.67%.

@@            Coverage Diff             @@
##           master     #495      +/-   ##
==========================================
+ Coverage   87.51%   87.88%   +0.37%     
==========================================
  Files         311      341      +30     
  Lines        5167     5730     +563     
==========================================
+ Hits         4522     5036     +514     
- Misses        645      694      +49     

Impacted Files	Coverage Δ
lib/fog/compute/google/models/images.rb	90.00% <ø> (+1.32%)	⬆️
.../compute/google/requests/reset_windows_password.rb	86.76% <86.76%> (ø)
lib/fog/compute/google.rb	100.00% <100.00%> (ø)
lib/fog/compute/google/models/server.rb	79.52% <100.00%> (+1.15%)	⬆️
lib/fog/google/models/sql/flags.rb	80.00% <0.00%> (-20.00%)	⬇️
lib/fog/google/models/sql/tiers.rb	80.00% <0.00%> (-20.00%)	⬇️
lib/fog/google/requests/sql/list_flags.rb	87.50% <0.00%> (-12.50%)	⬇️
lib/fog/google/requests/sql/list_tiers.rb	87.50% <0.00%> (-12.50%)	⬇️
lib/fog/compute/google/real.rb	100.00% <0.00%> (ø)
... and 33 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46d1bee...158e665. Read the comment docs.

[dvanbrug]

@Temikus Ok, squashed :-). Thanks again for all your help with this!

[Temikus]

@dvanbrug All tests pass, just one tiiiny problem:

  test_reset_windows_password                                    ERROR (271.09s)
Minitest::UnexpectedError:         ArgumentError: wrong number of arguments (given 1, expected 0)
            /tmp/build/7e99fb29/src/fog-google/lib/fog/compute/google/models/server.rb:346:in `serial_port_output'
            /tmp/build/7e99fb29/src/fog-google/test/integration/compute/core_compute/test_servers.rb:144:in `test_reset_windows_password'

Can you fixup the argument in the method (it's still set to positional):
serial_output = server.serial_port_output(4)

Sorry for the hassle :)

[dvanbrug]

@Temikus Doh! There we go, fixed up to use the new keyword parameter.

[Temikus]

@dvanbrug awesome, merged! I’ll start prepping the release next week.