Fog::Storage::GoogleJSON::File public/predefined_acl are not passed to api client #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…save (due to changed #put_object signature)
houndci-bot
reviewed
Jul 21, 2020
| @@ -105,7 +105,7 @@ def save | |||
|
|
|||
| options[:predefined_acl] ||= @predefined_acl | |||
|
|
|||
| service.put_object(directory.key, key, body, options) | |||
| service.put_object(directory.key, key, body, predefined_acl: options.delete(:predefined_acl), options) | |||
There was a problem hiding this comment.
Lint/Syntax: unexpected token tRPAREN
…save (due to changed #put_object signature)
|
@swistaczek thanks for getting this to our attention! So if I'm reading the changes in 2.7 right |
|
@Temikus thanks for the reply and for providing a great product to Ruby community! I see your point which is obviously a good catch. |
|
Sorry for hijacking this PR, but I found the same issue in copy_object: #505 |
|
@yosiat Yes, totally. Just change the method to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After updating my application to
fog-google: 1.10and ruby2.7.1I have noticed that even if my upstream code sets Storage object as public all my files are uploaded as a private one (without any ACL).I found out that the new Ruby version introduced breaking changes for method arguments.
Change in PR fixes this issue, however, I am not sure if a similar problem is not happening in other places.
CC: @icco, @Temikus and @plribeiro3000