Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRY up the retry methods in monitoring tests #501

Merged
merged 1 commit into from
Jul 23, 2020

Conversation

Temikus
Copy link
Member

@Temikus Temikus commented Jul 22, 2020

Drive-by fix for an old TODO in monitoring tests.

@codecov
Copy link

codecov bot commented Jul 22, 2020

Codecov Report

Merging #501 into master will increase coverage by 1.51%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #501      +/-   ##
==========================================
+ Coverage   87.50%   89.01%   +1.51%     
==========================================
  Files         341      341              
  Lines        5736     5736              
==========================================
+ Hits         5019     5106      +87     
+ Misses        717      630      -87     
Impacted Files Coverage Δ
.../fog/compute/google/requests/get_instance_group.rb 100.00% <0.00%> (+12.50%) ⬆️
...og/compute/google/requests/list_instance_groups.rb 100.00% <0.00%> (+12.50%) ⬆️
...g/compute/google/requests/delete_instance_group.rb 100.00% <0.00%> (+12.50%) ⬆️
...g/compute/google/requests/get_instance_template.rb 100.00% <0.00%> (+12.50%) ⬆️
...compute/google/requests/list_instance_templates.rb 100.00% <0.00%> (+12.50%) ⬆️
...ompute/google/requests/delete_instance_template.rb 100.00% <0.00%> (+12.50%) ⬆️
...pute/google/requests/get_instance_group_manager.rb 100.00% <0.00%> (+12.50%) ⬆️
...te/google/requests/list_instance_group_managers.rb 100.00% <0.00%> (+12.50%) ⬆️
...e/google/requests/delete_instance_group_manager.rb 100.00% <0.00%> (+12.50%) ⬆️
...google/requests/list_aggregated_instance_groups.rb 100.00% <0.00%> (+12.50%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58a9858...959b368. Read the comment docs.

@Temikus Temikus merged commit ac40c49 into fog:master Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant