Bring back integration tests for Fog-Google #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Setting IPv4 range directly in the network is no longer allowed - Add auto_create_subnetworks to the test factory to automatically kick off subnetworks - Leaving the attribute in so it doesn't break querying legacy subnetworks that still exist
This is a leftover from an old migration and should no longer be needed. Primary reason for removing - this prevents us from setting all attributes, e.g. `subnetworks` that are now critical.
Opted to lock down the CI through GitHub options a bit more prohibiting external contributors from running CI
Temikus
force-pushed
the
self-hosted-runners
branch
4 times, most recently
from
d0453e0 to
6ce5b85
Compare
They are now separated by API
Temikus
force-pushed
the
self-hosted-runners
branch
from
6ce5b85 to
1e45ca1
Compare
Use a properly instantiated request class instead of a Hash since this breaks the method call in Ruby3
1909 family of images no longer exists
|
Woo all tests pass 🙌 Except for SQL which is just being flaky as usual - I'll address it in another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to generous help of folks from MindMeister we can continue working on this project and have CI again ❤️
This PR returns CI integration and fixes all of the failing tests that are present.