Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle when no iscomplete correctly in callback #54

Merged
merged 5 commits into from
Nov 25, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion dash_uploader/callbacks.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
from pathlib import Path

from dash import __version__ as dashversion
from dash.exceptions import PreventUpdate
from dash.dependencies import Input, State

import dash_uploader.settings as settings
Expand All @@ -28,7 +29,7 @@ def create_dash_callback(callback, settings): # pylint: disable=redefined-outer

def wrapper(iscompleted, filenames, upload_id):
if not iscompleted:
return
raise PreventUpdate()

out = []
if filenames is not None:
Expand Down
4 changes: 4 additions & 0 deletions docs/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@ Maybe you already have an idea. If not, see if there are any open [issues](https
- Clone this repository. Change current directory to project root.
- Install [npm and Node.js](https://nodejs.org) for building JS.
- Install the JS dependencies by running `npm install` on the project root. This will create `node_modules` directory.
- Build the NPM modules
```
npm run build
```
- Create python virtual environment and activate it
- `pip install` this package in editable state with the `[dev]` flag.
```
Expand Down
Loading