Fixes issue with 32 bit builds of desync #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alignment issues with 64 bit fields in the struct causes 32 bit builds of desync to not work (panic in sync/atomic package). Re-arranging the members of the struct fixes this problem Based on suggestions found at golang/go#599 and golang/go#23345.
|
Discovered the problem and solution when trying to run this tool on a 32 bit machine. |
|
Thank you. I didn't know that, even though it actually says as much in https://golang.org/pkg/sync/atomic/#pkg-note-BUG |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alignment issues with 64 bit fields in the struct causes 32 bit builds of desync to not work (panic in sync/atomic package).
Re-arranging the members of the struct fixes this problem
Based on suggestions found at golang/go#599 and golang/go#23345.