Skip to content

Commit

Permalink
STRWEB-61 Lock enhanced-resolve to ~5.10.0 (#81)
Browse files Browse the repository at this point in the history
Platform complete is currently failing due to an issue with enhanced-resolve v5.11.0 (thank you @zburke for pointing to it): webpack/enhanced-resolve#362

This PR locks `enhanced-resolve` to "~5.10.0" it also upgrades `ts-loader` to make sure a single version of enhanced-resolve is used in the dependency tree.

Errors from https://jenkins-aws.indexdata.com/job/Automation/job/build-platform-complete-snapshot/13912/consoleText look like
```
"WARNING" in ": "./node_modules/@folio/stripes-core/src/components/ModuleTranslator/ModuleTranslator.js" "29:14-33"
": "export 'originalModules' (imported as 'originalModules') was "not found"": " in '../../ModulesContext' (possible exports: "ModulesContext, default, useModules"": ")"
 @ ./node_modules/@folio/stripes-core/src/components/ModuleTranslator/index.js 1:0-45 1:0-45
 @ ./node_modules/@folio/stripes-core/src/components/index.js 12:0-65 12:0-65
 @ ./node_modules/@folio/stripes-core/index.js 28:0-107 28:0-107 28:0-107 28:0-107 28:0-107
 @ ./node_modules/@folio/stripes-ui/src/index.js 1:0-43 2:0-4

"WARNING" in ": "./node_modules/@folio/stripes-core/src/components/ModuleTranslator/ModuleTranslator.js" "30:17-39"
": "export 'originalModules' (imported as 'originalModules') was "not found"": " in '../../ModulesContext' (possible exports: "ModulesContext, default, useModules"": ")"
 @ ./node_modules/@folio/stripes-core/src/components/ModuleTranslator/index.js 1:0-45 1:0-45
 @ ./node_modules/@folio/stripes-core/src/components/index.js 12:0-65 12:0-65
 @ ./node_modules/@folio/stripes-core/index.js 28:0-107 28:0-107 28:0-107 28:0-107 28:0-107
 @ ./node_modules/@folio/stripes-ui/src/index.js 1:0-43 2:0-4

"WARNING" in ": "./node_modules/@folio/stripes-core/src/components/ModuleTranslator/ModuleTranslator.js" "31:19-43"
": "export 'originalModules' (imported as 'originalModules') was "not found"": " in '../../ModulesContext' (possible exports: "ModulesContext, default, useModules"": ")"
 @ ./node_modules/@folio/stripes-core/src/components/ModuleTranslator/index.js 1:0-45 1:0-45
 @ ./node_modules/@folio/stripes-core/src/components/index.js 12:0-65 12:0-65
 @ ./node_modules/@folio/stripes-core/index.js 28:0-107 28:0-107 28:0-107 28:0-107 28:0-107
 @ ./node_modules/@folio/stripes-ui/src/index.js 1:0-43 2:0-4

"WARNING" in ": "./node_modules/@folio/stripes-core/src/components/ModuleTranslator/ModuleTranslator.js" "32:18-41"
": "export 'originalModules' (imported as 'originalModules') was "not found"": " in '../../ModulesContext' (possible exports: "ModulesContext, default, useModules"": ")"
 @ ./node_modules/@folio/stripes-core/src/components/ModuleTranslator/index.js 1:0-45 1:0-45
 @ ./node_modules/@folio/stripes-core/src/components/index.js 12:0-65 12:0-65
 @ ./node_modules/@folio/stripes-core/index.js 28:0-107 28:0-107 28:0-107 28:0-107 28:0-107
 @ ./node_modules/@folio/stripes-ui/src/index.js 1:0-43 2:0-4

"ERROR" in ": "./node_modules/@folio/stripes-core/src/App.js" "20:0-62"
": "Module "not found"": ": "Error"": ": Can't resolve 'stripes-config' in '/home/jenkins/workspace/Automation/build-platform-complete-snapshot/node_modules/@folio/stripes-core/src'"
 @ ./node_modules/@folio/stripes-core/src/init.js 5:0-24 8:28-31
 @ ./node_modules/@folio/stripes-core/index.js 35:0-45 35:0-45
 @ ./node_modules/@folio/stripes-ui/src/index.js 1:0-43 2:0-4

...
```

Fixes STRWEB-61
  • Loading branch information
mkuklis authored Nov 23, 2022
1 parent fa88325 commit dbc1439
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@
"svgo": "^1.2.2",
"svgo-loader": "^2.2.1",
"tapable": "^1.0.0",
"ts-loader": "^8.2.0",
"ts-loader": "^9.4.1",
"typescript": "^4.2.4",
"util-ex": "^0.3.15",
"webpack-dev-middleware": "^5.2.1",
Expand All @@ -92,5 +92,8 @@
"react": "^17.0.2",
"react-dom": "^17.0.2",
"webpack": "^5.58.1"
},
"resolutions": {
"enhanced-resolve": "~5.10.0"
}
}

0 comments on commit dbc1439

Please sign in to comment.