fix: Extra calls #1325
Merged
fix: Extra calls #1325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On snapshot we see extra calls to entitlementOptions where `page=undefined`. This does _not_ happen locally for me, which is confusing, but regardless I've added an enabled check to hopefully stop this behaviour refs ERM-3246 (But is not required for that functionality to work)
|
License CLA Stuck? (Developer should make sure that it is really stuck before clicking) |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On snapshot we see extra calls to entitlementOptions where
page=undefined. This does not happen locally for me, which is confusing, but regardless I've added an enabled check to hopefully stop this behaviourrefs ERM-3246 (But is not required for that functionality to work)