Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set a global default language #195

Merged
merged 5 commits into from
Mar 11, 2019
Merged

Set a global default language #195

merged 5 commits into from
Mar 11, 2019

Conversation

scottrippey
Copy link
Contributor

@scottrippey scottrippey commented Mar 7, 2019 •
edited
Loading

What

  • As a follow-up to Added defaultLanguage to font objects #194, this PR enables a global fontkit.setDefaultLanguage(lang) method.
  • Fonts will use the global language property, unless you explicitly override it via font.setDefaultLanguage(lang)
  • If a font property isn't available in the given language, it will attempt to find a backup language to use. For example, it will look for defaultLanguage, then "en", then just whatever is first.
  • Additionally, unit tests were added for fontkit.setDefaultLanguage as well as font.setDefaultLanguage

@scottrippey
Copy link
Contributor Author

FYI, I analyzed all the included fonts, and Amiri was the only font that included an alternate language ("ar" Arabic). Very glad to find this font to test with!

@scottrippey
Copy link
Contributor Author

@devongovett I matured this defaultLanguage approach a lot, and added unit tests! What do you think?

@devongovett devongovett merged commit abbe9c2 into foliojs:master Mar 11, 2019
@scottrippey scottrippey deleted the global-default-language branch March 11, 2019 18:07
@scottrippey
Copy link
Contributor Author

Thanks @devongovett !
What's the next step to get this published?

@devongovett
Copy link
Member

It is already published in v1.8.0! 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devongovett devongovett devongovett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scottrippey @devongovett