-
Notifications
You must be signed in to change notification settings - Fork 233
it doesn't work with Laravel 5.7 #376
Comments
I submitted a PR for it, hopefully it will get merged soon. My fork is at https://github.com/SonarSoftware/laravel-graphql if you need it desperately - once it's merged in, you can just point back at the main one. |
Not quite, you simple slapped it onto an existing PR you're working on ( #295 ) . There's no dedicated PR to upgrade the dependencies. But given the activity here it's questionable what will happen here anyway. |
Yeah, it's been pending so long I have been using my fork for months
anyway. Probably going to just hard fork soon and update to the new webonyx
library and drop support for older Laravel.
…On Fri, Sep 7, 2018, 12:20 AM Markus Podar ***@***.***> wrote:
I submitted a PR for it
Not quite, you simple slapped it onto an existing PR you're working on (
#295 <#295> ) .
There's no dedicated PR to upgrade the dependencies.
But given the activity here it's questionable what will happen here anyway.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#376 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ALkA-KIHz5ZSy1o1-FCDXY6v9TLmQXtsks5uYgI3gaJpZM4WaqiQ>
.
|
Isolated your commit and created a new pull request. |
To use the Laravel 5.7 compatible fork add this to your composer.json:
|
#378 has been merged into |
If you are looking for an actively maintained integration of GraphQL into Laravel, take a look at https://github.com/nuwave/lighthouse/ We support Laravel 5.7, have a Slack channel and a nice docs website |
Thanks All 👍 |
Laravel 5.7 has been released and this package doesn't support it yet.
so any plans to update the package ?
The text was updated successfully, but these errors were encountered: