Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Flag] use emoji flags with (auto) sizing #1190

Merged
merged 5 commits into from
Aug 9, 2021
Merged

[Flag] use emoji flags with (auto) sizing #1190

merged 5 commits into from
Aug 9, 2021

Conversation

lubber-de
Copy link
Member

@lubber-de lubber-de commented Nov 20, 2019 •
edited
Loading

Description

This PR replaces the sprite flag backgrounds by the new emoji flags keeping existing code bases backward compatible (you still use <i class="uk flag"></i> as before)

Additionally

  • almost all countries are available now (famfamfam sprite misses a lot of flags)
  • flags can now be sized
  • they are autosized by current font-size if no size class is given
  • the old sprite approach was kept into an additional theme famfamfam which one can easily switch back by changing the flag theme in theme.config

Screenshot

image
image
image

Closes

#1172
#660
#2244

@lubber-de lubber-de added type/feat Any feature requests or improvements lang/css Anything involving CSS state/has-docs A issue/PR which requires documentation changes and has the corresponding PR open in the docs repo labels Nov 20, 2019
@lubber-de lubber-de added this to the 2.8.3 milestone Nov 20, 2019
exoego
exoego previously approved these changes Nov 20, 2019
View reviewed changes
Copy link
Contributor

@exoego exoego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami
Copy link
Member

y0hami commented Nov 20, 2019

How do these look in a dropdown like this one https://fomantic-ui.com/modules/dropdown.html#search-selection

@lubber-de lubber-de mentioned this pull request Nov 20, 2019
Merged
@lubber-de
Copy link
Member Author

How do these look in a dropdown like this one https://fomantic-ui.com/modules/dropdown.html#search-selection

Hehe, i was expecting this question 😄
Here we go:
emoji_flags_dropdown

@lubber-de lubber-de requested a review from exoego November 20, 2019 23:16
y0hami
y0hami approved these changes Nov 21, 2019
View reviewed changes
Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

prudho
prudho approved these changes Nov 25, 2019
View reviewed changes
Copy link
Contributor

@prudho prudho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

exoego
exoego approved these changes Nov 25, 2019
View reviewed changes
Copy link
Contributor

@exoego exoego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami added state/on-hold Issues and pull requests which are on hold for any reason tag/breaking-change Any pull request which is waiting for a breaking change release labels Dec 22, 2019
@y0hami y0hami removed this from the 2.8.3 milestone Dec 22, 2019
@y0hami
Copy link
Member

y0hami commented Dec 22, 2019

I'm marking this as a breaking change since it does change the visual appearance of flags.

We had a small discussion about this in Discord awhile ago.

@lubber-de lubber-de added this to the 2.9.x milestone Dec 22, 2019
@y0hami y0hami removed this from the 2.9.0 milestone Dec 23, 2019
@lubber-de lubber-de added this to the 2.9.x milestone Feb 14, 2020
@lubber-de lubber-de mentioned this pull request Jun 1, 2020
Closed
@lubber-de lubber-de mentioned this pull request Jun 24, 2020
Closed
@ColinFrick ColinFrick mentioned this pull request Jul 1, 2020
Closed
This was referenced Jul 26, 2020
Open
Open
Open
Open
Closed
Open
@lubber-de lubber-de mentioned this pull request Mar 11, 2021
Closed
@lubber-de lubber-de merged commit 3ca5ff5 into fomantic:develop Aug 9, 2021
@lubber-de lubber-de deleted the feat/emoji_flags branch August 9, 2021 20:36
@lubber-de lubber-de removed the state/on-hold Issues and pull requests which are on hold for any reason label Aug 9, 2021
This was referenced Aug 9, 2021
Closed
Open
@lubber-de lubber-de mentioned this pull request Feb 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y0hami y0hami y0hami approved these changes

@prudho prudho prudho approved these changes

@ColinFrick ColinFrick ColinFrick approved these changes

@exoego exoego exoego approved these changes

Assignees
No one assigned
Labels
lang/css Anything involving CSS state/has-docs A issue/PR which requires documentation changes and has the corresponding PR open in the docs repo tag/breaking-change Any pull request which is waiting for a breaking change release type/feat Any feature requests or improvements
Projects
None yet
Milestone
2.9.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lubber-de @y0hami @exoego @ColinFrick @prudho