Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.6.1 #144

Merged
merged 22 commits into from
Oct 2, 2018
Merged

2.6.1 #144

merged 22 commits into from
Oct 2, 2018

Conversation

y0hami
Copy link
Member

@y0hami y0hami commented Oct 2, 2018

Version 2.6.1 - October 2, 2018

Bugs

  • Icon - Fixed comments icon from conflicting while inside comments component Thanks @ColinFrick #133
  • Modal - Fixed fullscreen modal from being stuck to the left of the screen Thanks @ColinFrick #135
  • Modal - Fixed fullscreen modals not working in IE11 Thanks @ColinFrick #136

Build Tools

  • Changed bower and composer package names from Semantic to Fomantic Thanks @salaros #140
  • Updated build process to use gulp 4 which removes dependency vulnerabilities **Thanks @acconrad #6566

Misc

  • Refactored buttons file to reducing the amount of code Thanks @ColinFrick #142

ColinFrick and others added 22 commits September 24, 2018 11:42
@ColinFrick
fix(comment): enforce dom structure for sub-comments
9432f26 
this allows "comments"-icon to be used in the actions section (or elsewhere)

Closes #131 / Semantic-Org/Semantic-UI#4404 / Semantic-Org/Semantic-UI#6595
@ColinFrick
fix(modal): set @fullScreenOffset to correct offset
3f0fe20 
Closes #130 / Semantic-Org/Semantic-UI#6587
@ColinFrick
fix(modal): increase importance of legacy modal class definition
9941732 
fullscreen modal class overrules the top / left definition of the legacy modals, which results in off-screen rendering of modals in IE11

Closes #134 / Semantic-Org/Semantic-UI#6597
@ColinFrick
fix(modal): increase importance of legacy modal class definition (scr…
c4eed66 
…olling)

Thanks @lubber-de for the hint
Merge pull request #135 from ColinFrick/fix/130
49d9b82 
[Modal] Fullscreen modal stuck to left edge of page
@salaros
chaning Bower's package name
7f50759
@salaros
changing Composer package's name to Fomantic UI
919ffd3
Merge pull request #140 from salaros/master
421e8c2 
fixing both Bower and Composer package names
@ColinFrick
feat(button): move consequence variations to mixin
be22acd 
Issue #128
Merge pull request #133 from ColinFrick/fix/131
c0d6acc 
[Icon] Comments icon inside "comment" component is not well aligned
Merge pull request #136 from ColinFrick/fix/134
f255e97 
[Modal] Fullscreen modals are not working in IE11
chore: update release notes
ebc5969
@ColinFrick
feat(button): move colors / primary / secondary to mixin
06f452c 
Closes #128
@lubber-de
[DropDown] Fix icon position over searchentry, stay focussed on keybo…
7d0276f 
…ard entries
@lubber-de
Missing src file
4ea71e5
Merge branch 'feat/128' of github.com:ColinFrick/Fomantic-UI into beta
df30d1b
Merge branch 'acc-upgrade-gulp4' of github.com:acconrad/Semantic-UI i…
80beaba 
…nto beta
chore: update release notes
fa736c8
Merge branch 'multiple-search-dropdown-fix' of github.com:lubber-de/F…
2abd763 
…omantic-UI into beta
chore: 2.6.1 build
77c60a5
chore: update version
a1ec555
chore: update date
ed26d84
@y0hami y0hami merged commit bb925b7 into master Oct 2, 2018
@y0hami y0hami mentioned this pull request Oct 2, 2018
Merged
@acconrad acconrad mentioned this pull request Oct 2, 2018
Closed
@lubber-de
Copy link
Member

The changelog for 2.6.1 misses listing of my drop down fix, although it's merged :sad:

@y0hami
Copy link
Member Author

y0hami commented Oct 3, 2018

@lubber-de 😱 sorry, I have a new PR to add them #147

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ColinFrick ColinFrick ColinFrick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@y0hami @lubber-de @ColinFrick @salaros