Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(segment): disabled, inverted and loading groups #1844

Merged
merged 1 commit into from
Jan 23, 2021

Conversation

lubber-de
Copy link
Member

Description

This PR adds support to use loading, disabled or inverted to the group variants instead of each single segment inside a group

Testcase

https://jsfiddle.net/lubber/dz30etxj/60/

Screenshot

image

Closes

#1842

@lubber-de lubber-de added type/feat Any feature requests or improvements lang/css Anything involving CSS state/awaiting-reviews Pull requests which are waiting for reviews labels Jan 19, 2021
@lubber-de lubber-de added this to the 2.8.8 milestone Jan 19, 2021
Copy link
Contributor

@exoego exoego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@ko2in ko2in left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lubber-de lubber-de merged commit 9ade8b7 into fomantic:develop Jan 23, 2021
@lubber-de lubber-de deleted the feat/loadingDisabledSegments branch January 23, 2021 15:54
@lubber-de lubber-de removed the state/awaiting-reviews Pull requests which are waiting for reviews label Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/css Anything involving CSS type/feat Any feature requests or improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants