Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dependency): support a possible installed v4 of less #1894

Merged
merged 6 commits into from
Jun 6, 2021
Merged

feat(dependency): support a possible installed v4 of less #1894

merged 6 commits into from
Jun 6, 2021

Conversation

lubber-de
Copy link
Member

@lubber-de lubber-de commented Feb 22, 2021 •
edited
Loading

Description

We fixed support for LESS 4 by #1819 , but the package.json retricts installation to 3.x if less 4.x is already installed by throwing "this version is not supported". Seems more and more people have LESS 4 installed now which breaks installation in some setup environments

I changed the dependency so every version >= 3.7 is supported now

Related

#1893

@lubber-de lubber-de added type/build Anything related to the build process state/awaiting-reviews Pull requests which are waiting for reviews type/chore Anything which is a project chore labels Feb 22, 2021
@lubber-de lubber-de added this to the 2.8.8 milestone Feb 22, 2021
@lubber-de lubber-de mentioned this pull request Feb 22, 2021
Closed
@lubber-de
Copy link
Member Author

Although this PR supports a higher major version of LESS, this will not help getting fomantic-ui installed with less 4.x installed, because the latest version of gulp-less still only supports less 3, so we are stuck until gulp-less changes its dependencies itself 😯

@lubber-de
Copy link
Member Author

lubber-de commented Feb 22, 2021 •
edited
Loading

Related gulp-less support for less 4 at gulp-community/gulp-less#312
and jescalan/accord#361

@lubber-de lubber-de modified the milestones: 2.8.8, 2.8.x Feb 23, 2021
@lubber-de lubber-de mentioned this pull request May 27, 2021
Merged
@lubber-de
Copy link
Member Author

lubber-de commented May 29, 2021 •
edited
Loading

The upcoming gulp-less PR gulp-community/gulp-less#313 will support LESS 4 by removing the unmaintained accord dependency.
I now changed the less dependency accordingly

exoego
exoego approved these changes May 29, 2021
View reviewed changes
Copy link
Contributor

@exoego exoego left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I did not know package.json supports multiple ranges support.

https://docs.npmjs.com/cli/v7/configuring-npm/package-json#dependencies
`range1 || range2~ Passes if either range1 or range2 are satisfied.

@lubber-de
Copy link
Member Author

I merge this, so we and dependabot are prepared once gulp-less releases their next version

@lubber-de lubber-de changed the title feat(chore): support a possible installed v4 of less feat(dependency): support a possible installed v4 of less Jun 6, 2021
@lubber-de lubber-de merged commit a246ad7 into fomantic:develop Jun 6, 2021
@lubber-de lubber-de deleted the supportLESS4 branch June 6, 2021 17:22
@lubber-de lubber-de modified the milestones: 2.8.x, 2.8.8 Jun 6, 2021
@lubber-de lubber-de removed the state/awaiting-reviews Pull requests which are waiting for reviews label Jun 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exoego exoego exoego approved these changes

@prudho prudho prudho approved these changes

@ko2in ko2in Awaiting requested review from ko2in

@ColinFrick ColinFrick Awaiting requested review from ColinFrick

@y0hami y0hami Awaiting requested review from y0hami

Assignees
No one assigned
Labels
type/build Anything related to the build process type/chore Anything which is a project chore
Projects
None yet
Milestone
2.8.8
Development

Successfully merging this pull request may close these issues.
3 participants
@lubber-de @exoego @prudho