Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make fake_bind compatible to runic. #3106

Merged
merged 3 commits into from
Jan 22, 2025
Merged

Make fake_bind compatible to runic. #3106

merged 3 commits into from
Jan 22, 2025

Conversation

j-fu
Copy link
Contributor

@j-fu j-fu commented Nov 25, 2024

Runic is a new "runic" formatter for Julia code.
Due to peculiarities of implementation, format toggling is better handeled by wrapping around whole functions or macros, see

See fredrikekre/Runic.jl#107 (comment)

So in order to make Pluto notebooks invariant under runic formatting I propose to modify fake_bind accordingly.

Try this Pull Request!

Open Julia and type:

julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/j-fu/Pluto.jl", rev="runic_fake_bind")
julia> using Pluto

@fredrikekre
Copy link
Contributor

(Simply adding return in front of the quote would be an alternative fix if you don't want to move the comments to the outside of the macro.)

@fonsp
Copy link
Owner

fonsp commented Nov 25, 2024

Let's go with the return then! See #3072 for previous discussion

@fonsp
Copy link
Owner

fonsp commented Dec 13, 2024

Can you update the PR?

@pjaap
Copy link

pjaap commented Jan 9, 2025

@j-fu ping

j-fu and others added 2 commits January 10, 2025 14:19
instead of wrapping the whole macro into format off/on
@fonsp
Copy link
Owner

fonsp commented Jan 17, 2025

Thanks! Can you check if my last commit is correct? Or was the extra newline intentional?

@j-fu
Copy link
Contributor Author

j-fu commented Jan 20, 2025

LGTM

@fonsp fonsp merged commit 8ca430d into fonsp:main Jan 22, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants