Fall back to legacy getUserMedia for MediaStream instance #1991
Conversation
| <%api.MediaDevices:mediaDevices%> | ||
| var promise = mediaDevices.getUserMedia({audio: true}); | ||
| promise.then(function() {}); | ||
| // This string makes this a callback test: callback( |
There was a problem hiding this comment.
@queengooborg this isn't very nice. Do you have any thoughts on how to write the detection instead? Can we more explicitly mark tests as callback tests?
There was a problem hiding this comment.
Actually, this string isn't needed! As long as the string callback is present, then we're good to go, no open parenthesis needed!
There was a problem hiding this comment.
Isn't this the code that determines if it's a callback test?
Line 90 in 52df4d5
There's an open paren there...
There was a problem hiding this comment.
Oh I was looking at the functions above (we should probably split it off into its own function), hmm... We could perhaps turn it into a regex check to find a comma or right parenthesis afterwards as well?
There was a problem hiding this comment.
Can we add the test type as a bit of info in the YAML perhaps, to serve at least as an override for the detected type?
There was a problem hiding this comment.
So with #2253 I can drop the comment here.
This is based on testing Chrome 41 and 42 with a staging version of mdn-bcd-collector with these updated tests: foolip/mdn-bcd-collector#1991 Part of mdn#7844.
|
Hmm, this actually breaks the custom tests for |
|
Closing in favor of #2589. |
Fixes #1520.