Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MNT] - Saving settings to group reports #218

Closed
TomDonoghue opened this issue Sep 30, 2021 · 1 comment
Closed

[MNT] - Saving settings to group reports #218

TomDonoghue opened this issue Sep 30, 2021 · 1 comment
Assignees
@TomDonoghue
Labels
1.1 Targetted for a fooof 1.1 release.

Comments

@TomDonoghue
Copy link
Member

When saving a report, for a single model, the settings get saved, whereas for a group of models, the settings do not get saved. This is a little inconsistent, and also it would be useful save settings to group report, in particular for the use case of fitting a group of spectra across different settings, to compare performance.

Also: another option is to toggle saving settings to reports on/off. Could add this for both (?).
@TomDonoghue TomDonoghue self-assigned this Sep 30, 2021
@TomDonoghue TomDonoghue added the 2.0 Targetted for the specparam 2.0 release. label Sep 30, 2021
@TomDonoghue TomDonoghue added 1.1 Targetted for a fooof 1.1 release. and removed 2.0 Targetted for the specparam 2.0 release. labels Jun 29, 2023
@TomDonoghue TomDonoghue mentioned this issue Jun 29, 2023
Merged
@TomDonoghue
Copy link
Member Author

Updates added over in #267 - so closing this here to move the discussion & finalizing there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TomDonoghue TomDonoghue

Labels
1.1 Targetted for a fooof 1.1 release.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TomDonoghue