Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] - Update reports (add settings) #267

Merged
merged 4 commits into from
Jun 29, 2023
Merged

[MNT] - Update reports (add settings) #267

merged 4 commits into from
Jun 29, 2023

Conversation

TomDonoghue
Copy link
Member

Responds to #218

Main updates:

  • adds settings to a saved out FOOOFGroup report
  • adds the option to choose whether settings are saved for saving out both FOOOF and FOOOFGroup reports
  • tweaks some sizing to make the reports work / look good
  • adds the option to pass in explicit figure sizes for model plots

Note: for review, the code changes here are fairly simple - but it would be useful to check that when running the report generation code locally, that the sizing and layout looks alright!

@TomDonoghue TomDonoghue requested a review from ryanhammonds June 29, 2023 19:12
@TomDonoghue TomDonoghue added the 1.1 Targetted for a fooof 1.1 release. label Jun 29, 2023
Copy link
Contributor

@ryanhammonds ryanhammonds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reports look good when I use the new option!

@TomDonoghue TomDonoghue merged commit 208fc09 into main Jun 29, 2023
@TomDonoghue TomDonoghue deleted the grep branch June 29, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.1 Targetted for a fooof 1.1 release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants