Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MNT] - Small fix up for null models #280

Merged
merged 1 commit into from
Jul 7, 2023
Merged

[MNT] - Small fix up for null models #280

merged 1 commit into from
Jul 7, 2023

Conversation

TomDonoghue
Copy link
Member

Couple small fixes:

  • in FOOOFGroup, update the docs to match that the attributes are called n_null_ and null_inds_
  • in report generation, use the n_null_ attribute instead of counting missing exponents

@TomDonoghue TomDonoghue added the 1.1 Targetted for a fooof 1.1 release. label Jul 6, 2023
@TomDonoghue TomDonoghue merged commit f01399c into main Jul 7, 2023
@TomDonoghue TomDonoghue deleted the null branch July 7, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanhammonds ryanhammonds ryanhammonds approved these changes

@voytek voytek voytek approved these changes

Assignees
No one assigned
Labels
1.1 Targetted for a fooof 1.1 release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TomDonoghue @voytek @ryanhammonds