Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create setters/getters for check modes and fix management #294

Merged
merged 8 commits into from
Jul 23, 2023

Conversation

SM-Figueroa
Copy link
Contributor

This fix adds setters and getters for run_modes in fooof objects in fit.py. The dictionary returned by get_description() in info.py includes attributes for all run_modes. The get_fooof() and get_group() functions in group.py are now updated to probably transfer run mode settings from the current object to newly instantiated objects. Documentation relating to run_modes was updated in all files.

This Pull Request relates to this issue.

@TomDonoghue TomDonoghue changed the base branch from main to checkmodes July 23, 2023 17:35
@fooof-tools fooof-tools deleted a comment from codecov-commenter Jul 23, 2023
@fooof-tools fooof-tools deleted a comment from codecov-commenter Jul 23, 2023
@TomDonoghue
Copy link
Member

Awesome, thanks @SM-Figueroa! I redirected this PR to #293 and did a merge commit to combine the additions here with those (you can see the changes in the last commit). I'm going to merge this PR now, which will add your changes to the checkmodes branch, and things can be finalized and merged to main from there! Thanks for your contribution!

@TomDonoghue TomDonoghue merged commit 6e817a1 into fooof-tools:checkmodes Jul 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants