Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] - Update parameter Stepper object #295

Merged
merged 1 commit into from
Jul 25, 2023
Merged

[MNT] - Update parameter Stepper object #295

merged 1 commit into from
Jul 25, 2023

Conversation

TomDonoghue
Copy link
Member

@TomDonoghue TomDonoghue commented Jul 24, 2023

This tweaks the checks on the Stepper object to allow for using the Stepper object to step along decreasing parameter values.

For example, this would have previously raised an error, but now works:
exp_stepper = Stepper(2.5, 0.5, -0.25)

@TomDonoghue TomDonoghue changed the base branch from main to checkmodes July 24, 2023 06:21
@fooof-tools fooof-tools deleted a comment from codecov-commenter Jul 24, 2023
@TomDonoghue TomDonoghue changed the title [WIP] - Update parameter Stepper object [MNT] - Update parameter Stepper object Jul 24, 2023
@TomDonoghue TomDonoghue requested a review from ryanhammonds July 24, 2023 14:12
@TomDonoghue TomDonoghue added the 1.1 Targetted for a fooof 1.1 release. label Jul 24, 2023
Copy link
Contributor

@ryanhammonds ryanhammonds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@TomDonoghue TomDonoghue merged commit d49edb3 into checkmodes Jul 25, 2023
@TomDonoghue TomDonoghue deleted the stepper branch July 25, 2023 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.1 Targetted for a fooof 1.1 release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants