Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release #56

Merged
merged 21 commits into from
Dec 27, 2017
Merged

Release #56

merged 21 commits into from
Dec 27, 2017

Conversation

TomDonoghue
Copy link
Member

@TomDonoghue TomDonoghue commented Dec 15, 2017

These are all updates for the repository to be ready for release, as a tagged version here on Github, and uploaded to PYPI. No changes to the actual codebase.

It includes some updates to the README.
Going to branch (https://github.com/voytekresearch/fooof/tree/release) might be easier than diff for seeing those changes.

I think this makes it ready for PyPi, but I'm opening this early, so anyone who knows more about this process can eyeball it all and make sure it's on the right track.

@codecov-io
Copy link

codecov-io commented Dec 15, 2017

Codecov Report

Merging #56 into master will decrease coverage by 0.16%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
- Coverage   97.29%   97.12%   -0.17%     
==========================================
  Files          32       37       +5     
  Lines        1034     1878     +844     
==========================================
+ Hits         1006     1824     +818     
- Misses         28       54      +26
Impacted Files Coverage Δ
setup.py 0% <0%> (ø) ⬆️
fooof/__init__.py 100% <100%> (ø) ⬆️
fooof/version.py 100% <100%> (ø)
fooof/analysis.py 87.5% <0%> (-5.84%) ⬇️
fooof/tests/conftest.py 88.23% <0%> (-3.07%) ⬇️
fooof/core/modutils.py 97.36% <0%> (-2.64%) ⬇️
fooof/tests/test_utils.py 97.56% <0%> (-2.44%) ⬇️
fooof/fit.py 95.19% <0%> (-1.13%) ⬇️
fooof/core/io.py 94.54% <0%> (-1.11%) ⬇️
fooof/core/reports.py 100% <0%> (ø) ⬆️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0132629...20dc9e3. Read the comment docs.

Copy link
Contributor

@voytek voytek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good good

@TomDonoghue TomDonoghue merged commit 515f8da into master Dec 27, 2017
@TomDonoghue TomDonoghue deleted the release branch December 27, 2017 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants