feat: increment unit tests coverage #1044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ChangeProposal & CommunityPoolSpendProposal unit tests
teamchong
reviewed
Nov 8, 2022
There was a problem hiding this comment.
thanks, @MonikaCat, look good to me. but since the folder structure has changed a lot, I will patch the changes to my PR tonight, and keep this one open.
8 tasks
teamchong
approved these changes
Nov 9, 2022
teamchong
added a commit
that referenced
this pull request
Nov 22, 2022
## Description * Include new unit tests of #1044 * Move duplicated components / screens into `ui` package * Update web socket connection, try to fix #1045 * Various bug fixes * Setup docker images ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow-up issues.* I have... - [X] ran linting - [X] wrote tests where necessary - [X] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [X] targeted the correct branch - [X] provided a link to the relevant issue or specification - [X] reviewed "Files changed" and left comments if necessary - [X] confirmed all CI checks have passed - [X] added an entry to the `CHANGELOG.md` file Co-authored-by: Riccardo <[email protected]> Co-authored-by: Magic Cat <[email protected]> Co-authored-by: Ellie <[email protected]>
ankurdotb
pushed a commit
to cheqd/big-dipper-2.0-cosmos
that referenced
this pull request
Dec 22, 2022
Closes: #XXXX [BDU-580](https://forbole.atlassian.net/browse/BDU-580) <!-- Add a description of the changes that this PR introduces and the files that are the most critical to review. --> --- *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] ran linting - [x] wrote tests where necessary - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [x] targeted the correct branch - [x] provided a link to the relevant issue or specification - [x] reviewed "Files changed" and left comments if necessary - [x] confirmed all CI checks have passed - [x] added an entry to the `CHANGELOG.md` file
ankurdotb
pushed a commit
to cheqd/big-dipper-2.0-cosmos
that referenced
this pull request
Dec 22, 2022
Closes: #XXXX [BDU-580](https://forbole.atlassian.net/browse/BDU-580) <!-- Add a description of the changes that this PR introduces and the files that are the most critical to review. --> --- *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] ran linting - [x] wrote tests where necessary - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [x] targeted the correct branch - [x] provided a link to the relevant issue or specification - [x] reviewed "Files changed" and left comments if necessary - [x] confirmed all CI checks have passed - [x] added an entry to the `CHANGELOG.md` file
ankurdotb
added a commit
to cheqd/big-dipper-2.0-cosmos
that referenced
this pull request
Dec 22, 2022
* Change testnet-5 parameters * Run graphql codegen and disable generation for desmos profiles * feat: increment unit tests coverage (forbole#1044) Closes: #XXXX [BDU-580](https://forbole.atlassian.net/browse/BDU-580) <!-- Add a description of the changes that this PR introduces and the files that are the most critical to review. --> --- *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] ran linting - [x] wrote tests where necessary - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [x] targeted the correct branch - [x] provided a link to the relevant issue or specification - [x] reviewed "Files changed" and left comments if necessary - [x] confirmed all CI checks have passed - [x] added an entry to the `CHANGELOG.md` file * Update jest snapshots * Update pull-request.yml Co-authored-by: Magic Cat <[email protected]> Co-authored-by: Ankur Banerjee <[email protected]>
boosik
pushed a commit
to Carina-labs/big-dipper-2.0-cosmos
that referenced
this pull request
Feb 13, 2023
## Description Closes: #XXXX [BDU-580](https://forbole.atlassian.net/browse/BDU-580) <!-- Add a description of the changes that this PR introduces and the files that are the most critical to review. --> --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] ran linting - [x] wrote tests where necessary - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [x] targeted the correct branch - [x] provided a link to the relevant issue or specification - [x] reviewed "Files changed" and left comments if necessary - [x] confirmed all CI checks have passed - [x] added an entry to the `CHANGELOG.md` file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #XXXX
BDU-580
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
CHANGELOG.mdfile