Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use GetMissingHeights() in enqueueMissingBlocks() & in parse blocks cmd #89

Merged
merged 5 commits into from
Dec 28, 2022

Conversation

huichiaotsou
Copy link
Contributor

@huichiaotsou huichiaotsou commented Dec 21, 2022

Description

following the request from @maiquanghiep : https://forbole.atlassian.net/browse/BDU-489?focusedCommentId=17477

Checklist

  • Targeted PR against correct branch.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit tests.
  • Re-reviewed Files changed in the Github PR explorer.

@MonikaCat MonikaCat added the automerge Automatically merge PR once all prerequisites pass label Dec 22, 2022
Copy link
Contributor

@MonikaCat MonikaCat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, LGTM

@MonikaCat MonikaCat requested a review from RiccardoM December 22, 2022 04:20
Copy link
Contributor

@RiccardoM RiccardoM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@mergify mergify bot merged commit 86c1cc5 into cosmos/v0.45.x Dec 28, 2022
@mergify mergify bot deleted the aaron/parse_missing_blocks branch December 28, 2022 17:05
MonikaCat pushed a commit that referenced this pull request Jan 19, 2024
…se blocks` cmd (#89)

## Description


following the request from @maiquanghiep : https://forbole.atlassian.net/browse/BDU-489?focusedCommentId=17477

## Checklist
- [x] Targeted PR against correct branch.
- [x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
- [ ] Wrote unit tests.  
- [x] Re-reviewed `Files changed` in the Github PR explorer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge PR once all prerequisites pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants