Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

W-17237086 fix: updates based on live API #26

Merged
merged 7 commits into from
Jan 17, 2025
Merged

W-17237086 fix: updates based on live API #26

merged 7 commits into from
Jan 17, 2025

Conversation

mdonnalley
Copy link
Contributor

What does this PR do?

Make updates based on live sf eval API

What issues does this PR fix or reference?

@W-17237086@

cristiand391
cristiand391 reviewed Jan 17, 2025
View reviewed changes
src/agentTester.ts Outdated Show resolved Hide resolved
cristiand391
cristiand391 approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@cristiand391 cristiand391 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (compared with new updates in the SF EVAL api contract doc, assuming the new lowercase states changes were done on purpose by them).

@cristiand391 cristiand391 merged commit b8749cb into main Jan 17, 2025
15 checks passed
@cristiand391 cristiand391 deleted the mdonnalley/api-updates branch January 17, 2025 21:05
@iowillhoit iowillhoit changed the title fix: updates based on live API W-17237086 fix: updates based on live API Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristiand391 cristiand391 cristiand391 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mdonnalley @cristiand391 @svc-cli-bot