Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] build: use a bundler (esbuild) along with vsce to package vsix files #4087

Closed
wants to merge 21 commits into from

Conversation

mohanraj-r
Copy link
Contributor

@mohanraj-r mohanraj-r commented May 7, 2022

What does this PR do?

Uses esbuild to bundle (and treeshake) JS files before packaging them into vsix with vsce. This would lead to

What issues does this PR fix or reference?

@W-6980161@

Functionality Before

  • vsce package was used to produce vsix files

Functionality After

  • vsce package is used along with esbuild to produce vsix files

Notes

Future considerations 👉

  • QA
    • Even when bundling isn't working correctly (missing to identify files to bundle due to dynamic imports e.g.) the vsix files build and install without any errors
      • Have to watch for extension activation errors in VSCode dev console, ext host log etc
      • Without automated e2e tests to verify correct activation and e2e functionality of the extensions, bundling could risk the quality of the releases
  • Debugging / user error reporting
    • Stack traces become harder to read and less informative with bundled packages

@mohanraj-r mohanraj-r requested a review from a team as a code owner May 7, 2022 02:05
@mohanraj-r mohanraj-r requested a review from jeffb-sfdc May 7, 2022 02:05
@mohanraj-r mohanraj-r marked this pull request as draft May 7, 2022 02:05
as it is not working as expected and causing other errors
@mohanraj-r mohanraj-r closed this May 9, 2022
@CristiCanizales CristiCanizales deleted the mohanraj-r/build_vsix_with_bundler branch August 15, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant