-
-
Notifications
You must be signed in to change notification settings - Fork 718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created a Functional Clock using HTML, CSS and JavaScript . Closes #1164 #1263
Conversation
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good!
Merged
Thank you for your contribution! Your pull request has been merged. The files have been reset for the next contributor. What's next?If you're looking for more ways to contribute, I invite you to check out my other projects. Just click here to find more. These projects contain real issues that you can help resolve. You can also check out the Influences section in the README to find more projects similar to this one. Also please leave a star to this project if you feel it helped you, i would really appreciate it. I look forward to seeing your contributions! |
Thanks |
This PR introduces changes made to tasks/html/hard/clock
where i introduced the functionality to the clock.
[X] Solved an issue/task
[ ] Bugfix
[X] Feature
[X] Code style update (formatting, local variables)
[X] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:
What is the current behavior?
Currently this clock is running perfectly based on realtime of your area .
Issue Number: #1164
What is the new behavior?
Added hands and functionality to the clock