feat(dialect): passed the chosen dialect to the unit-test scaffolder

form8ion · Nov 23, 2021 · d8c43e5 · d8c43e5
1 parent 870dded
commit d8c43e5
Show file tree

Hide file tree

Showing 4 changed files with 32 additions and 6 deletions.
diff --git a/src/scaffolder-test.js b/src/scaffolder-test.js
@@ -194,7 +194,15 @@ suite('javascript project scaffolder', () => {
       )
       .resolves(ciServiceResults);
     testing.default
-      .withArgs({projectRoot, tests, visibility, vcs: vcsDetails, unitTestFrameworks, decisions})
+      .withArgs({
+        projectRoot,
+        tests,
+        visibility,
+        vcs: vcsDetails,
+        unitTestFrameworks,
+        decisions,
+        dialect: chosenDialect
+      })
       .resolves(testingResults);
     linting.default
       .withArgs({

diff --git a/src/scaffolder.js b/src/scaffolder.js
@@ -73,7 +73,15 @@ export async function scaffold(options) {
     decisions,
     dialect
   });
-  const testingResults = await scaffoldTesting({projectRoot, tests, visibility, vcs, unitTestFrameworks, decisions});
+  const testingResults = await scaffoldTesting({
+    projectRoot,
+    tests,
+    visibility,
+    vcs,
+    unitTestFrameworks,
+    decisions,
+    dialect
+  });
   const [nodeVersion, npmResults, dialectResults] = await Promise.all([
     scaffoldNodeVersion({projectRoot, nodeVersionCategory}),
     scaffoldNpmConfig({projectType, projectRoot, registries}),

diff --git a/src/testing/scaffolder-test.js b/src/testing/scaffolder-test.js
@@ -8,6 +8,7 @@ suite('testing scaffolder', () => {
   let sandbox;
   const projectRoot = any.string();
   const visibility = any.word();
+  const dialect = any.word();
   const unitTestingDevDependencies = any.listOf(any.string);
   const unitTestingEslintConfigs = any.listOf(any.string);
   const unitTestNextSteps = any.listOf(any.simpleObject);
@@ -24,7 +25,7 @@ suite('testing scaffolder', () => {
     sandbox.stub(javascript, 'scaffoldUnitTesting');
 
     javascript.scaffoldUnitTesting
-      .withArgs({projectRoot, visibility, vcs, frameworks: unitTestFrameworks, decisions})
+      .withArgs({projectRoot, visibility, vcs, frameworks: unitTestFrameworks, decisions, dialect})
       .resolves({
         devDependencies: unitTestingDevDependencies,
         scripts: unitTestScripts,
@@ -38,7 +39,15 @@ suite('testing scaffolder', () => {
 
   test('that unit testing is scaffolded if the project will be unit tested', async () => {
     assert.deepEqual(
-      await scaffoldTesting({projectRoot, visibility, tests: {unit: true}, vcs, unitTestFrameworks, decisions}),
+      await scaffoldTesting({
+        projectRoot,
+        visibility,
+        tests: {unit: true},
+        vcs,
+        unitTestFrameworks,
+        decisions,
+        dialect
+      }),
       {
         devDependencies: ['@travi/any', ...unitTestingDevDependencies],
         scripts: unitTestScripts,

diff --git a/src/testing/scaffolder.js b/src/testing/scaffolder.js
@@ -7,10 +7,11 @@ export default async function ({
   tests: {unit, integration},
   vcs,
   unitTestFrameworks,
-  decisions
+  decisions,
+  dialect
 }) {
   const unitResults = unit
-    ? await scaffoldUnitTesting({projectRoot, visibility, vcs, frameworks: unitTestFrameworks, decisions})
+    ? await scaffoldUnitTesting({projectRoot, visibility, vcs, frameworks: unitTestFrameworks, decisions, dialect})
     : {};
 
   return deepmerge({devDependencies: [...(unit || integration) ? ['@travi/any'] : []]}, unitResults);