Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not recreate form instance if the form json is not changed deeply #598

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

TanyaGashtold
Copy link
Contributor

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-XXXX

Description

What changed?

  • store form json in refs and compare it with current props to define if the instance should be recreated
  • use the same callback reference to on and off events

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@brendanbond brendanbond merged commit 1ceda0d into master Jan 29, 2025
5 checks passed
@brendanbond brendanbond deleted the fixed-instance-recreation-when-json-not-changed branch January 29, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants