Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exporting form error codes #6

Merged
merged 3 commits into from
May 11, 2022
Merged

Conversation

colevscode
Copy link
Member

@smakosh smakosh added the enhancement New feature or request label May 9, 2022
@colevscode colevscode force-pushed the feature/export-typed-error-codes branch from 61f37c4 to dabe0c9 Compare May 10, 2022 08:14
@colevscode colevscode requested review from smakosh and rohitdatta May 10, 2022 08:18
@colevscode
Copy link
Member Author

colevscode commented May 10, 2022

Getting the isKnownError working required some typescript shenannegans, but should work.

Here's an example of how it might be used to create localized error messages (untested):

const response = await client.submitForm(...)
if (hasErrors(response.body)) {
  for (const error of response.body.errors) {
    if (isFieldError(error)) {
      querySelector(`.myForm [name=${error.field}]`).style.border = "solid red"
      querySelector(`.myForm .error#{error.field}`).innerText = translateFieldErrorMessage(error.field, error.code)
    } else if(isKnownError(error)) {
      querySelector(`.myForm .error#formErrors`).innerText = translateErrorMessage(error.code)
    } else {
      querySelector(`.myForm .error#formErrors`).innerText = translateUnknownErrorMessage()
      console.log(`UnknownError: ${error.message}`)
    }
  }
}

@colevscode colevscode force-pushed the feature/export-typed-error-codes branch from 7b9e79d to 1c5b9aa Compare May 10, 2022 23:06
@colevscode colevscode changed the title [WIP] Exporting form error codes Exporting form error codes May 11, 2022
@colevscode colevscode merged commit c8fae7e into master May 11, 2022
@colevscode colevscode deleted the feature/export-typed-error-codes branch May 11, 2022 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants