Fix very slow regexp #87

caub · 2018-05-12T08:55:57Z

No description provided.

caub · 2018-05-20T18:07:09Z

@formulahendry I did a very slight change to fix this 'infinite' running regex, (just [^<>]*? to [^<>]?)

the meaning is slightly different, but it's necessary to avoid the exponential backtracking that comes with [^<>]*[^\s/<>=]*

some hints from: http://www.rexegg.com/regex-explosive-quantifiers.html

Could you merge it?

caub · 2018-06-08T10:16:30Z

@formulahendry Can you check it please?

garygreen · 2018-07-31T13:15:19Z

I did a very slight change to fix this 'infinite' running regex, (just [^<>]*? to [^<>]?)

Yet the PR has hundreds of lines changed with formatting stuff and merge problems. You might have more luck getting this merged if you changed a small amount of code... 😄

caub · 2018-07-31T15:39:58Z

right, done

Can @formulahendry see this?

also single or double quotes? there is a mix of them in the sources

caub · 2018-08-04T14:06:12Z

I think I'll make a quick cron script that gently ping @formulahendry every week, to hopefully merge this

caub · 2018-08-04T14:08:28Z

package.json

@@ -78,13 +78,30 @@
                },
                "auto-close-tag.excludedTags": {
                    "type": "array",
-                    "default": ["area", "base", "br", "col", "command", "embed", "hr", "img", "input", "keygen", "link", "meta", "param", "source", "track", "wbr"],


npm i has reformatted it

formulahendry · 2018-08-09T08:19:22Z

package.json

                    "description": "Set the tag list that would not be auto closed.",
                    "scope": "resource"
                },
                "auto-close-tag.SublimeText3Mode": {
                    "type": "boolean",
-                    "default": false,
+                    "default": true,


We'd not change the default setting if we could not make sure most of users want this.

I want this!

formulahendry · 2018-08-09T08:19:57Z

src/getCloseTag.ts

@@ -0,0 +1,27 @@
+export default function getCloseTag(text: string, excludedTags: string[]): string {
+    const regex = /<(\/?[a-zA-Z][a-zA-Z0-9:\-_.]*)(?:\s+[^<>]?[^\s/<>=]*)*\s?>/g;


<abc key=value> would not work correctly.

ah yes indeed it's broken, need to add many more tests, thanks for noticing

// original regex: 'lol <a href="/ok"></a><abc key="value"> </'.match(/<(\/?[a-zA-Z][a-zA-Z0-9:\-_.]*)(?:\s+[^<>]*?[^\s/<>=]+?)*?\s?>/g) ["<a href="/ok">", "</a>", "<abc key="value">"] // with my change: 'lol <a href="/ok"></a><abc key="value"> </'.match(/<(\/?[a-zA-Z][a-zA-Z0-9:\-_.]*)(?:\s+[^<>]?[^\s/<>=]*)*\s?>/g) ["</a>"]

formulahendry · 2018-08-10T02:50:07Z

src/getCloseTag.ts

@@ -0,0 +1,27 @@
+export default function getCloseTag(text: string, excludedTags: string[]): string {
+    const regex = /<(\/?[a-zA-Z][a-zA-Z0-9:\-_.]*)(?:\s+[^<>]*?[^\s/<>=]*)*\s?>/g;


'<abc => should not get close tag.

The biggest concern is that: although this may improve the performance, but might break several kinds of scenario,

(?:\s+[^<>]*?[^\s/<>=]*)* would make [^\s/<>=]* useless
(?:\s+[^<>]*?[^\s/<>=]*)* is similar to (?:\s+[^<>]*?)*

Thanks for the advices
<abc => is a tag with an empty attribute key and value? or something else?

currently I hit again the slowness issue in the last test case, I think I'll try a different approach than the big regex, and search backward with smaller regexes and a loop

arrow function shouldn't trigger auto-close: #5

search backward would be great idea! 👍

oh you meant '<abc =>' like in a string? (or a comment, ..). Honestly I don't think this extension can be perfect, with jsx expressions we'd need to parse them to be 100% correct, and it's not even possible when we are in an unfinished one. So we might need to accept false-positiives like <foo><bar x=1 y={'<lol'} ></ that gives lol currently

I don't mind if a few rare edge cases are broken, if that means the performance issues are fixed. Performance a big concern for this extension.

(I just wish we could add a timeout to regexps so they will fail if they take too long!)

(Or is it really a regexp problem? I wonder if a time check inside the while might be able to break out of problematic loops.)

formulahendry · 2018-08-10T03:09:39Z

test/getCloseTag.test.ts

@@ -0,0 +1,61 @@
+import { readFileSync } from "fs";


Need to enable test code running, similar to https://github.com/formulahendry/vscode-auto-rename-tag/blob/3141e782cadbb121b8c0fbf13683a88374e6a1b1/package.json#L54

Also need to follow the test structure: https://github.com/formulahendry/vscode-auto-close-tag/blob/master/test/extension.test.ts

will try to add tests, (code-runner would need tests too, if I figure it, I'd update that project too)

caub · 2018-08-25T17:17:18Z

Ok, so I made a new approach by searching tags backward, it's not 100% robust, we can try to imrpove it more, like the current one anyway (jsx expressions can be very tricky), but no more performance issues at least

it's tested like the pointers you showed and run in CI

garethedwards-tass · 2024-01-12T08:30:37Z

This has helped me a bit, thank you, but also your code wasn't catering for excludedTags, and I think this does the job.

`const TAG_RE = /<(/?[a-zA-Z][a-zA-Z0-9:_.-])(?![\s\S]</?[a-zA-Z])/;

caub · 2024-01-12T18:22:57Z

Sorry guys I can't maintain this PR anymore, please go ahead with a new PR

garethedwards-tass · 2024-01-15T02:09:24Z

@caub curious, are you using different tools or just not this extension anymore ? I've built in some of this functionality into our internal tools to avoid devs having to use this extension.

caub · 2024-01-17T22:36:16Z

I went back to sublime-text

garethedwards-tass · 2024-01-18T00:15:48Z

@caub we took this route a few times in the past, curious what languages you're working with? we're writing CFML and I've made some headway using your code, its not perfect but it works ok.

caub · 2024-01-18T08:19:26Z

@garethedwards-tass you can definitely make progress, try to make you own PR and the maintainer may merge it

I'm only working on JS (node+react), so sublimetext support things decently

caub changed the title ~~deprecation warnings + indent~~ deprecation warnings and other cleaning May 12, 2018

caub force-pushed the c branch from 0e82221 to ca0992e Compare May 12, 2018 10:11

caub force-pushed the c branch 3 times, most recently from b5c3daa to 95acb27 Compare May 20, 2018 15:01

caub mentioned this pull request May 20, 2018

Crash with SublimeText3Mode (with an example) #86

Open

caub force-pushed the c branch from 95acb27 to ec76c21 Compare May 20, 2018 18:04

caub force-pushed the c branch from 1193cef to 043e715 Compare May 21, 2018 06:31

caub changed the title ~~deprecation warnings and other cleaning~~ Fix very slow regexp Jun 10, 2018

This was referenced Jun 10, 2018

SVG code crashes auto-close-tag #82

Open

Typing in img onLoad causes vs code helper to spike to 100% cpu usage. #70

Open

sublime mode slow to complete #34

Open

Catastrophic backtracking of regexp match in getCloseTag #41

Open

caub force-pushed the c branch 6 times, most recently from d72e74a to a6de765 Compare July 31, 2018 15:35

caub force-pushed the c branch 2 times, most recently from 9dab3ae to 7ca2272 Compare August 4, 2018 14:04

caub commented Aug 4, 2018

View reviewed changes

formulahendry reviewed Aug 9, 2018

View reviewed changes

caub force-pushed the c branch from 7ca2272 to feaa37b Compare August 9, 2018 09:15

formulahendry reviewed Aug 10, 2018

View reviewed changes

caub force-pushed the c branch from b3f1f80 to f0f0c5c Compare August 25, 2018 11:30

fix formulahendry#86 explosive regex

04ed4b8

caub force-pushed the c branch from f0f0c5c to 04ed4b8 Compare August 25, 2018 17:15

caub closed this Jan 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix very slow regexp #87

Fix very slow regexp #87

caub commented May 12, 2018

caub commented May 20, 2018 •

edited

Loading

caub commented Jun 8, 2018

garygreen commented Jul 31, 2018 •

edited

Loading

caub commented Jul 31, 2018 •

edited

Loading

caub commented Aug 4, 2018 •

edited

Loading

caub Aug 4, 2018

formulahendry Aug 9, 2018

joeysino Nov 22, 2019

formulahendry Aug 9, 2018

caub Aug 9, 2018 •

edited

Loading

formulahendry Aug 10, 2018

formulahendry Aug 10, 2018 •

edited

Loading

formulahendry Aug 10, 2018

caub Aug 10, 2018 •

edited

Loading

formulahendry Aug 10, 2018

formulahendry Aug 10, 2018

caub Aug 25, 2018

joeysino Nov 22, 2019 •

edited

Loading

formulahendry Aug 10, 2018

formulahendry Aug 10, 2018

caub Aug 25, 2018 •

edited

Loading

caub commented Aug 25, 2018

garethedwards-tass commented Jan 12, 2024

caub commented Jan 12, 2024

garethedwards-tass commented Jan 15, 2024

caub commented Jan 17, 2024

garethedwards-tass commented Jan 18, 2024

caub commented Jan 18, 2024

		@@ -0,0 +1,27 @@
		export default function getCloseTag(text: string, excludedTags: string[]): string {
		const regex = /<(\/?[a-zA-Z][a-zA-Z0-9:\-_.])(?:\s+[^<>]?[^\s/<>=])*\s?>/g;

Fix very slow regexp #87

Fix very slow regexp #87

Conversation

caub commented May 12, 2018

caub commented May 20, 2018 • edited Loading

caub commented Jun 8, 2018

garygreen commented Jul 31, 2018 • edited Loading

caub commented Jul 31, 2018 • edited Loading

caub commented Aug 4, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

caub Aug 9, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

formulahendry Aug 10, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

caub Aug 10, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

joeysino Nov 22, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

caub Aug 25, 2018 • edited Loading

Choose a reason for hiding this comment

caub commented Aug 25, 2018

garethedwards-tass commented Jan 12, 2024

caub commented Jan 12, 2024

garethedwards-tass commented Jan 15, 2024

caub commented Jan 17, 2024

garethedwards-tass commented Jan 18, 2024

caub commented Jan 18, 2024

caub commented May 20, 2018 •

edited

Loading

garygreen commented Jul 31, 2018 •

edited

Loading

caub commented Jul 31, 2018 •

edited

Loading

caub commented Aug 4, 2018 •

edited

Loading

caub Aug 9, 2018 •

edited

Loading

formulahendry Aug 10, 2018 •

edited

Loading

caub Aug 10, 2018 •

edited

Loading

joeysino Nov 22, 2019 •

edited

Loading

caub Aug 25, 2018 •

edited

Loading