Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unresponsive #72

Open
thany opened this issue Nov 20, 2018 · 4 comments
Open

Unresponsive #72

thany opened this issue Nov 20, 2018 · 4 comments

Comments

@thany
Copy link

thany commented Nov 20, 2018

VS Code becomes unresponsive in the weirdest situations.

See here: microsoft/vscode#61138

I opened that ticket because I believe the code editor should not freeze because of a misbehaving extension, but please fix this behaviour.

You appear to be using nasty regular expressions to find the closing tag or something, which is really, really bad practice.

@infctr
Copy link

infctr commented Nov 29, 2018

I had same issue with this extension, the editor kind of freezes, I'm able to edit, but not use any hotkeys and other extensions seem to get unresponsive. Usually I can't wait till it get responsive and reload the window from command pallette

Disabled the extension for .svg files with

  "auto-rename-tag.activationOnLanguage": [
    "html",
    "js",
    "jsx",
    "tsx"
  ]

@thany
Copy link
Author

thany commented Nov 30, 2018

This problem applies to several other files as welll So far, I've found this issue in SVG, CHTML (razor templates), JSON (html in a value), and Mustache.

Disabling this extension for those file types is not the way to go. For now, disabling/deleting the whole extension is the way to, if I'm completely honest. This extension uses nasty regexes to find the closing tag, and we have known that that's a bad idea for years and years.

The real solution is for this extension to properly tokenize the document and find the closing tag that way. And whaddayaknow, VSCode already (sort of) does that, when highlighting matching tags and brackets. I'm sure an extension can be made to tap into that.

@VAggrippino
Copy link

I have this problem too. VSCode stops responding to any keyboard input. It's easily reproducible and often happens when I'm modifying the properties of an HTML element. If I put some inline SVG into a page it happens every time. If I disable the Auto Rename Tag extension, the problem goes away.

@tdd
Copy link

tdd commented Jan 25, 2019

This is due to the extension hogging the entire extensionHost process, preventing all other exts (some of which hijack keys such as Backspace and Return in their related syntaxes) from passing regular key behavior through to Code.

@SimonSiefke SimonSiefke mentioned this issue Jan 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants